Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047265
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] [POS2] POSmajoralways2021-06-28 16:282021-07-12 16:10
ReportermigueldejuanaView Statuspublic 
Assigned Tomigueldejuana 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047265: Combos with higher discount than line amount, generate negative lines

DescriptionApplying a Combo, if one of the families have an discount and that discount is higher than the total gross of the line, we get a negative line.
In that case, we should apply the maximum amount and the line will have a 100% of discount.
Steps To Reproduce- Create or modify a combo adding a fixed discount 0f 1000€ to one of the families.
- Go to web POS, add the combo to the ticket (the product of the family with the discount must be less than 1000€)
- We will a combo discount higher that the line amount and we get a negative line
- ERROR! We cannot have negative lines due to a discount applied
Proposed SolutionWhen applying the combo discount, ensure that the discount amount is not more than the line amount
TagsNOR
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045405 closedranjith_qualiantech_com Error applying coupon. The last line is negative. 
related to defect 0047365 closedmigueldejuana Coupons with higher discount than line amount, generate negative lines 

-  Notes
(0129956)
hgbot (developer)
2021-06-29 16:46

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/12 [^]
(0129957)
hgbot (developer)
2021-06-29 16:48

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 84172c2a8837333c8f073b03f3279d309cd3456a
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-06-29T13:37:34+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/84172c2a8837333c8f073b03f3279d309cd3456a [^]

Fixed ISSUE-0047265: Combos with higher discount than line amount, generate negative lines

- Set discount amount to line amount when discount amount is higher

---
M web/org.openbravo.retail.discounts.combo/app/model/business-logic/discounts-engine/engine/rules/combo-discount.js
---
(0129958)
hgbot (developer)
2021-06-29 16:48

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/12 [^]

- Issue History
Date Modified Username Field Change
2021-06-28 16:28 migueldejuana New Issue
2021-06-28 16:28 migueldejuana Assigned To => migueldejuana
2021-06-28 16:28 migueldejuana Triggers an Emergency Pack => No
2021-06-28 16:28 migueldejuana Relationship added related to 0045405
2021-06-28 17:18 rafaroda Tag Attached: NOR
2021-06-29 16:46 hgbot Note Added: 0129956
2021-06-29 16:48 hgbot Resolution open => fixed
2021-06-29 16:48 hgbot Status new => resolved
2021-06-29 16:48 hgbot Note Added: 0129957
2021-06-29 16:48 hgbot Note Added: 0129958
2021-07-08 14:35 migueldejuana Relationship added related to 0047365
2021-07-12 08:49 migueldejuana Project POS2 => Retail Modules
2021-07-12 16:10 guilleaer Review Assigned To => guilleaer
2021-07-12 16:10 guilleaer Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker