Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047016 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | have not tried | 2021-06-08 09:36 | 2021-07-22 16:04 | |||
| Reporter | plujan | View Status | public | |||||
| Assigned To | hernan-dp | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047016: [CY] The elements of two different ticket lines share the same testid | |||||||
| Description | Although the testid tags should be unique, if a ticket has more than one line, all its testids are named in a similar fashion, making them not unique. | |||||||
| Steps To Reproduce | 1. Add a product to a blank ticket. Inspect its elements and check the data-testid tags to see values like "obpos2TicketLineCheckbox-checkbox", "obpos2TicketLine-ticketLineQuantity", etc. 2. Add a different product to get two lines in the ticket. Inspect both lines elements and check the values of its testids coincide. This is a defect as the testids must be unique. | |||||||
| Proposed Solution | Inherit the index of the line as the grids components do. For example, a testid currently named "obpos2TicketLine-ticketLineQuantity" could be named "obpos2TicketLine-LineContent-1-ticketLineQuantity" | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0130683) hgbot (developer) 2021-07-22 02:25 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/624 [^] |
|
(0130684) hgbot (developer) 2021-07-22 02:25 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/605 [^] |
|
(0130686) hgbot (developer) 2021-07-22 09:23 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: ccd545c12ca57c269404ef999b052cfa1a8e8784 Author: hernan-dp <h.de.prada1@gmail.com> Date: 2021-07-21T21:23:07-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ccd545c12ca57c269404ef999b052cfa1a8e8784 [^] fixes ISSUE-47016: Adds unique ids to property component. --- M web-jspack/org.openbravo.core2/src/components/PropertyComponent/PropertyComponent.jsx --- |
|
(0130687) hgbot (developer) 2021-07-22 09:23 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/605 [^] |
|
(0130700) hgbot (developer) 2021-07-22 16:04 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 88a7ffc0055a3a6e12ed7f6679df3683912219d8 Author: hernan-dp <h.de.prada1@gmail.com> Date: 2021-07-22T14:04:26+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/88a7ffc0055a3a6e12ed7f6679df3683912219d8 [^] fixes ISSUE-47016: Adds unique ids to ticket lines components. --- M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/__test__/TicketArea.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePrediscountPrice/TicketLinePrediscountPrice.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/ProductConfiguration.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineQuantity.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSchemaLabel/TicketLineSchemaLabel.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSchemaLabel/__test__/TicketLineSchemaLabel.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/ProductConfiguration.test.jsx M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLines.test.jsx M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCell/__test__/TicketLineRenderCell.test.jsx --- |
|
(0130701) hgbot (developer) 2021-07-22 16:04 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/624 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-06-08 09:36 | plujan | New Issue | |
| 2021-06-08 09:36 | plujan | Assigned To | => Retail |
| 2021-06-08 09:36 | plujan | Resolution time | => 1627250400 |
| 2021-06-08 09:36 | plujan | Triggers an Emergency Pack | => No |
| 2021-06-14 10:27 | guilleaer | Status | new => acknowledged |
| 2021-07-15 16:43 | dmiguelez | Resolution time | 1627250400 => 1638313200 |
| 2021-07-22 02:25 | hgbot | Note Added: 0130683 | |
| 2021-07-22 02:25 | hgbot | Note Added: 0130684 | |
| 2021-07-22 09:23 | dmiguelez | Status | acknowledged => scheduled |
| 2021-07-22 09:23 | dmiguelez | Assigned To | Retail => hernan-dp |
| 2021-07-22 09:23 | hgbot | Resolution | open => fixed |
| 2021-07-22 09:23 | hgbot | Status | scheduled => closed |
| 2021-07-22 09:23 | hgbot | Note Added: 0130686 | |
| 2021-07-22 09:23 | hgbot | Note Added: 0130687 | |
| 2021-07-22 16:04 | hgbot | Note Added: 0130700 | |
| 2021-07-22 16:04 | hgbot | Note Added: 0130701 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |