Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047016POS2POSpublic2021-06-08 09:362021-07-22 16:04
Reporterplujan 
Assigned Tohernan-dp 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047016: [CY] The elements of two different ticket lines share the same testid
DescriptionAlthough the testid tags should be unique, if a ticket has more than one line, all its testids are named in a similar fashion, making them not unique.
Steps To Reproduce1. Add a product to a blank ticket. Inspect its elements and check the data-testid tags to see values like "obpos2TicketLineCheckbox-checkbox", "obpos2TicketLine-ticketLineQuantity", etc.
2. Add a different product to get two lines in the ticket. Inspect both lines elements and check the values of its testids coincide. This is a defect as the testids must be unique.
Proposed SolutionInherit the index of the line as the grids components do. For example, a testid currently named "obpos2TicketLine-ticketLineQuantity" could be named "obpos2TicketLine-LineContent-1-ticketLineQuantity"
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-08 09:36plujanNew Issue
2021-06-08 09:36plujanAssigned To => Retail
2021-06-08 09:36plujanResolution time => 1627250400
2021-06-08 09:36plujanTriggers an Emergency Pack => No
2021-06-14 10:27guilleaerStatusnew => acknowledged
2021-07-15 16:43dmiguelezResolution time1627250400 => 1638313200
2021-07-22 02:25hgbotNote Added: 0130683
2021-07-22 02:25hgbotNote Added: 0130684
2021-07-22 09:23dmiguelezStatusacknowledged => scheduled
2021-07-22 09:23dmiguelezAssigned ToRetail => hernan-dp
2021-07-22 09:23hgbotResolutionopen => fixed
2021-07-22 09:23hgbotStatusscheduled => closed
2021-07-22 09:23hgbotNote Added: 0130686
2021-07-22 09:23hgbotNote Added: 0130687
2021-07-22 16:04hgbotNote Added: 0130700
2021-07-22 16:04hgbotNote Added: 0130701

Notes
(0130683)
hgbot   
2021-07-22 02:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/624 [^]
(0130684)
hgbot   
2021-07-22 02:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/605 [^]
(0130686)
hgbot   
2021-07-22 09:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: ccd545c12ca57c269404ef999b052cfa1a8e8784
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-07-21T21:23:07-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ccd545c12ca57c269404ef999b052cfa1a8e8784 [^]

fixes ISSUE-47016: Adds unique ids to property component.

---
M web-jspack/org.openbravo.core2/src/components/PropertyComponent/PropertyComponent.jsx
---
(0130687)
hgbot   
2021-07-22 09:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/605 [^]
(0130700)
hgbot   
2021-07-22 16:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 88a7ffc0055a3a6e12ed7f6679df3683912219d8
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-07-22T14:04:26+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/88a7ffc0055a3a6e12ed7f6679df3683912219d8 [^]

fixes ISSUE-47016: Adds unique ids to ticket lines components.

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketArea/__test__/TicketArea.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePrediscountPrice/TicketLinePrediscountPrice.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/ProductConfiguration.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineQuantity.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSchemaLabel/TicketLineSchemaLabel.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSchemaLabel/__test__/TicketLineSchemaLabel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/ProductConfiguration.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/TicketLines.test.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/TicketLineRenderCell/__test__/TicketLineRenderCell.test.jsx
---
(0130701)
hgbot   
2021-07-22 16:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/624 [^]