Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046926
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-06-01 12:362022-01-11 15:34
Reportergorka_gilView Statuspublic 
Assigned Tojustin_patterson 
PrioritynormalResolutionfixedFixed in VersionRR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046926: JIRA 1123: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state

DescriptionThe feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state
Steps To ReproduceIn POS2 enable the preference
Do a sale of 10
Pay 12
Check in backoffice payment details
paid=10

In POS enable the preference
Do a sale of 10
Pay 12
Check in backoffice payment details
paid=10
chenage=2
Proposed SolutionIncorporate this logic to addPayment state action
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0046875 closedgorka_gil POS2 Change not printed in the ticket 

-  Notes
(0133401)
hgbot (developer)
2021-11-29 11:11

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/642 [^]
(0133411)
hgbot (developer)
2021-11-30 11:42

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/743 [^]
(0133661)
hgbot (developer)
2021-12-13 16:40

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/743 [^]
(0133662)
hgbot (developer)
2021-12-13 16:41

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/750 [^]
(0133666)
hgbot (developer)
2021-12-13 18:31

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/642 [^]
(0133667)
hgbot (developer)
2021-12-13 18:31

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/657 [^]
(0133881)
hgbot (developer)
2021-12-21 16:41

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/657 [^]
(0133882)
hgbot (developer)
2021-12-21 16:41

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: dbf3a943e2f9aabfe8196623f33cc9244968c8c1
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 21-12-2021 11:15:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dbf3a943e2f9aabfe8196623f33cc9244968c8c1 [^]

Fixed ISSUE-46926: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state
            - Added new utility function calculateChange to process and add changePayments to the ticket
            - New logic takes in ticket and payload, finds payments with the "overpayments" property set when split payments are used, finds the cash payment with change if not, forms new changePayments using these payments and returns them as an array inside of new ticket object property "changePayments" for final processing on ticket completion
            - Added test class CompleteTicketUtils-CalculateChange.test.js which contains a suite of tests for the new logic

---
A web-test/model/business-object/ticket/CompleteTicketUTils-CalculateChange.test.js
M .gitignore
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
---
(0133886)
hgbot (developer)
2021-12-21 18:58

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c8f721839f82c2501457e27e9907e537ebede9cc
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 21-12-2021 18:56:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c8f721839f82c2501457e27e9907e537ebede9cc [^]

Revert "Fixed ISSUE-46926: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state"

This reverts commit dbf3a943e2f9aabfe8196623f33cc9244968c8c1.

---
M .gitignore
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
R web-test/model/business-object/ticket/CompleteTicketUTils-CalculateChange.test.js
---
(0133887)
shuehner (administrator)
2021-12-21 18:59

 Re-opening issue as commit was reverted (caused jest test errors)
(0133894)
hgbot (developer)
2021-12-22 11:42

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/664 [^]
(0133905)
hgbot (developer)
2021-12-22 15:57

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/664 [^]
(0133906)
hgbot (developer)
2021-12-22 15:57

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c5cab2ad7ffb82ba7dfd5b985fb0940af9d4798d
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 22-12-2021 12:16:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c5cab2ad7ffb82ba7dfd5b985fb0940af9d4798d [^]

Fixed ISSUE-46926: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state
- Added new utility function calculateChange to process and add changePayments to the ticket
- New logic takes in ticket and payload, finds payments with the "overpayments" property set when split payments are used, finds the cash payment with change if not, finds exact payments if they exist also, forms new changePayment and payment objects using these payments and returns them as arrays inside of new ticket
- Added test class CompleteTicketUtils-CalculateChange.test.js which contains a suite of tests for the new logic

---
A web-test/model/business-object/ticket/CompleteTicketUTils-CalculateChange.test.js
M .gitignore
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
---
(0134228)
hgbot (developer)
2022-01-11 15:34

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/750 [^]

- Issue History
Date Modified Username Field Change
2021-06-01 12:36 gorka_gil New Issue
2021-06-01 12:36 gorka_gil Assigned To => Retail
2021-06-01 12:36 gorka_gil OBNetwork customer => No
2021-06-01 12:36 gorka_gil Triggers an Emergency Pack => No
2021-06-01 12:36 gorka_gil Status new => acknowledged
2021-06-01 12:37 gorka_gil Relationship added related to 0046875
2021-11-12 08:56 guilleaer Assigned To Retail => justin_patterson
2021-11-12 08:56 guilleaer Status acknowledged => scheduled
2021-11-12 08:56 guilleaer Summary When printing a loaded ticket from backend it is missing the change => JIRA 1123: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state
2021-11-12 08:56 guilleaer Description Updated View Revisions
2021-11-12 08:56 guilleaer Steps to Reproduce Updated View Revisions
2021-11-12 08:56 guilleaer Proposed Solution updated
2021-11-29 11:11 hgbot Merge Request Status => open
2021-11-29 11:11 hgbot Note Added: 0133401
2021-11-30 11:42 hgbot Note Added: 0133411
2021-12-13 16:40 hgbot Note Added: 0133661
2021-12-13 16:41 hgbot Note Added: 0133662
2021-12-13 18:31 hgbot Note Added: 0133666
2021-12-13 18:31 hgbot Note Added: 0133667
2021-12-21 12:39 hgbot Merge Request Status open => approved
2021-12-21 16:41 hgbot Note Added: 0133881
2021-12-21 16:41 hgbot Resolution open => fixed
2021-12-21 16:41 hgbot Status scheduled => closed
2021-12-21 16:41 hgbot Fixed in Version => RR22Q1
2021-12-21 16:41 hgbot Note Added: 0133882
2021-12-21 18:58 hgbot Note Added: 0133886
2021-12-21 18:59 shuehner Note Added: 0133887
2021-12-21 18:59 shuehner Status closed => new
2021-12-21 18:59 shuehner Resolution fixed => open
2021-12-21 18:59 shuehner Fixed in Version RR22Q1 =>
2021-12-22 11:42 hgbot Note Added: 0133894
2021-12-22 15:57 hgbot Resolution open => fixed
2021-12-22 15:57 hgbot Status new => closed
2021-12-22 15:57 hgbot Note Added: 0133905
2021-12-22 15:57 hgbot Fixed in Version => RR22Q1
2021-12-22 15:57 hgbot Note Added: 0133906
2022-01-11 15:34 hgbot Note Added: 0134228

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker