Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0046926 | Retail Modules | Web POS | public | 2021-06-01 12:36 | 2022-01-11 15:34 |
|
| Reporter | gorka_gil | |
| Assigned To | justin_patterson | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR22Q1 | |
| Merge Request Status | approved |
| Review Assigned To | |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0046926: JIRA 1123: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state |
| Description | The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state |
| Steps To Reproduce | In POS2 enable the preference
Do a sale of 10
Pay 12
Check in backoffice payment details
paid=10
In POS enable the preference
Do a sale of 10
Pay 12
Check in backoffice payment details
paid=10
chenage=2 |
| Proposed Solution | Incorporate this logic to addPayment state action |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0046875 | | closed | gorka_gil | POS2 | Change not printed in the ticket |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-06-01 12:36 | gorka_gil | New Issue | |
| 2021-06-01 12:36 | gorka_gil | Assigned To | => Retail |
| 2021-06-01 12:36 | gorka_gil | OBNetwork customer | => No |
| 2021-06-01 12:36 | gorka_gil | Triggers an Emergency Pack | => No |
| 2021-06-01 12:36 | gorka_gil | Status | new => acknowledged |
| 2021-06-01 12:37 | gorka_gil | Relationship added | related to 0046875 |
| 2021-11-12 08:56 | guilleaer | Assigned To | Retail => justin_patterson |
| 2021-11-12 08:56 | guilleaer | Status | acknowledged => scheduled |
| 2021-11-12 08:56 | guilleaer | Summary | When printing a loaded ticket from backend it is missing the change => JIRA 1123: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state |
| 2021-11-12 08:56 | guilleaer | Description Updated | bug_revision_view_page.php?rev_id=23308#r23308 |
| 2021-11-12 08:56 | guilleaer | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=23310#r23310 |
| 2021-11-12 08:56 | guilleaer | Proposed Solution updated | |
| 2021-11-29 11:11 | hgbot | Merge Request Status | => open |
| 2021-11-29 11:11 | hgbot | Note Added: 0133401 | |
| 2021-11-30 11:42 | hgbot | Note Added: 0133411 | |
| 2021-12-13 16:40 | hgbot | Note Added: 0133661 | |
| 2021-12-13 16:41 | hgbot | Note Added: 0133662 | |
| 2021-12-13 18:31 | hgbot | Note Added: 0133666 | |
| 2021-12-13 18:31 | hgbot | Note Added: 0133667 | |
| 2021-12-21 12:39 | hgbot | Merge Request Status | open => approved |
| 2021-12-21 16:41 | hgbot | Note Added: 0133881 | |
| 2021-12-21 16:41 | hgbot | Resolution | open => fixed |
| 2021-12-21 16:41 | hgbot | Status | scheduled => closed |
| 2021-12-21 16:41 | hgbot | Fixed in Version | => RR22Q1 |
| 2021-12-21 16:41 | hgbot | Note Added: 0133882 | |
| 2021-12-21 18:58 | hgbot | Note Added: 0133886 | |
| 2021-12-21 18:59 | shuehner | Note Added: 0133887 | |
| 2021-12-21 18:59 | shuehner | Status | closed => new |
| 2021-12-21 18:59 | shuehner | Resolution | fixed => open |
| 2021-12-21 18:59 | shuehner | Fixed in Version | RR22Q1 => |
| 2021-12-22 11:42 | hgbot | Note Added: 0133894 | |
| 2021-12-22 15:57 | hgbot | Resolution | open => fixed |
| 2021-12-22 15:57 | hgbot | Status | new => closed |
| 2021-12-22 15:57 | hgbot | Note Added: 0133905 | |
| 2021-12-22 15:57 | hgbot | Fixed in Version | => RR22Q1 |
| 2021-12-22 15:57 | hgbot | Note Added: 0133906 | |
| 2022-01-11 15:34 | hgbot | Note Added: 0134228 | |
|
Notes |
|
|
(0133401)
|
|
hgbot
|
|
2021-11-29 11:11
|
|
|
|
|
(0133411)
|
|
hgbot
|
|
2021-11-30 11:42
|
|
|
|
|
(0133661)
|
|
hgbot
|
|
2021-12-13 16:40
|
|
|
|
|
(0133662)
|
|
hgbot
|
|
2021-12-13 16:41
|
|
|
|
|
(0133666)
|
|
hgbot
|
|
2021-12-13 18:31
|
|
|
|
|
(0133667)
|
|
hgbot
|
|
2021-12-13 18:31
|
|
|
|
|
(0133881)
|
|
hgbot
|
|
2021-12-21 16:41
|
|
|
|
|
(0133882)
|
|
hgbot
|
|
2021-12-21 16:41
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: dbf3a943e2f9aabfe8196623f33cc9244968c8c1
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 21-12-2021 11:15:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dbf3a943e2f9aabfe8196623f33cc9244968c8c1 [^]
Fixed ISSUE-46926: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state
- Added new utility function calculateChange to process and add changePayments to the ticket
- New logic takes in ticket and payload, finds payments with the "overpayments" property set when split payments are used, finds the cash payment with change if not, forms new changePayments using these payments and returns them as an array inside of new ticket object property "changePayments" for final processing on ticket completion
- Added test class CompleteTicketUtils-CalculateChange.test.js which contains a suite of tests for the new logic
---
A web-test/model/business-object/ticket/CompleteTicketUTils-CalculateChange.test.js
M .gitignore
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
---
|
|
|
|
(0133886)
|
|
hgbot
|
|
2021-12-21 18:58
|
|
|
|
|
|
|
Re-opening issue as commit was reverted (caused jest test errors) |
|
|
|
(0133894)
|
|
hgbot
|
|
2021-12-22 11:42
|
|
|
|
|
(0133905)
|
|
hgbot
|
|
2021-12-22 15:57
|
|
|
|
|
(0133906)
|
|
hgbot
|
|
2021-12-22 15:57
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c5cab2ad7ffb82ba7dfd5b985fb0940af9d4798d
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 22-12-2021 12:16:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c5cab2ad7ffb82ba7dfd5b985fb0940af9d4798d [^]
Fixed ISSUE-46926: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state
- Added new utility function calculateChange to process and add changePayments to the ticket
- New logic takes in ticket and payload, finds payments with the "overpayments" property set when split payments are used, finds the cash payment with change if not, finds exact payments if they exist also, forms new changePayment and payment objects using these payments and returns them as arrays inside of new ticket
- Added test class CompleteTicketUtils-CalculateChange.test.js which contains a suite of tests for the new logic
---
A web-test/model/business-object/ticket/CompleteTicketUTils-CalculateChange.test.js
M .gitignore
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteTicket.js
---
|
|
|
|
(0134228)
|
|
hgbot
|
|
2022-01-11 15:34
|
|
|