0046878: Undo Button does not do anything while undoing a discount that allows multiple instances

Description

Undo Button does not do anything while undoing a discount that allows multiple instances.

The logic to find the discount is wrong as it tries to find a discount instance that does not exist

Steps To Reproduce

Create a User Defined Amount discount with allows multiple instances
Login on POS
Add a product
Add the following created discount
Click undo

Discount does not get deleted but undo label dissapears

Proposed Solution

Review the following logic:
                undo: function() {
                    let manualPromotions = receipt.get('discountsFromUser').manualPromotions;
                    let promotionToDelete = manualPromotions.find(manualPromotion=>{
                        return (manualPromotion.id === promotionRule.id && manualPromotion.discountinstance === promotionRule.discountinstance);
                    }
                    );
                    if (promotionToDelete) {
                        manualPromotions.splice(manualPromotions.indexOf(promotionToDelete), 1);
                    }
                    receipt.calculateReceipt();
                    receipt.set('undo', null);
                    receipt.set('multipleUndo', null);
                }

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0129288) hgbot (developer) 2021-06-09 20:23	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/473 [^]

(0129309) hgbot (developer) 2021-06-10 09:45	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 2021a5e993a75a8d6855c2a0b967dbaea7a10c0e Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-06-10T07:45:10+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2021a5e993a75a8d6855c2a0b967dbaea7a10c0e [^] Fixed BUG-46878: Check if promotionrule allow multiple instances --- M web/org.openbravo.retail.posterminal/js/model/discounts.js ---

(0129310) hgbot (developer) 2021-06-10 09:45	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/473 [^]

Issue History
Date Modified	Username	Field	Change
2021-05-28 08:12	guillermogil	New Issue
2021-05-28 08:12	guillermogil	Assigned To	=> Retail
2021-05-28 08:12	guillermogil	OBNetwork customer	=> Gold
2021-05-28 08:12	guillermogil	Resolution time	=> 1623708000
2021-05-28 08:12	guillermogil	Triggers an Emergency Pack	=> No
2021-05-28 08:19	guillermogil	Steps to Reproduce Updated	View Revisions
2021-05-28 08:19	guillermogil	Proposed Solution updated
2021-06-06 23:13	rqueralta	Assigned To	Retail => rqueralta
2021-06-06 23:13	rqueralta	Status	new => scheduled
2021-06-09 20:23	hgbot	Merge Request Status	=> open
2021-06-09 20:23	hgbot	Note Added: 0129288
2021-06-10 09:45	hgbot	Merge Request Status	open => approved
2021-06-10 09:45	hgbot	Resolution	open => fixed
2021-06-10 09:45	hgbot	Status	scheduled => closed
2021-06-10 09:45	hgbot	Fixed in Version	=> RR21Q3
2021-06-10 09:45	hgbot	Note Added: 0129309
2021-06-10 09:45	hgbot	Note Added: 0129310