Openbravo Issue Tracking System - Retail Modules | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0046878 | Retail Modules | Discounts and Promotions | public | 2021-05-28 08:12 | 2021-06-10 09:45 |
| Reporter | guillermogil | ||||
| Assigned To | rqueralta | ||||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | RR21Q3 | |||
| Merge Request Status | |||||
| Review Assigned To | |||||
| OBNetwork customer | |||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0046878: Undo Button does not do anything while undoing a discount that allows multiple instances | ||||
| Description | Undo Button does not do anything while undoing a discount that allows multiple instances. The logic to find the discount is wrong as it tries to find a discount instance that does not exist | ||||
| Steps To Reproduce | Create a User Defined Amount discount with allows multiple instances Login on POS Add a product Add the following created discount Click undo Discount does not get deleted but undo label dissapears | ||||
| Proposed Solution | Review the following logic: undo: function() { let manualPromotions = receipt.get('discountsFromUser').manualPromotions; let promotionToDelete = manualPromotions.find(manualPromotion=>{ return (manualPromotion.id === promotionRule.id && manualPromotion.discountinstance === promotionRule.discountinstance); } ); if (promotionToDelete) { manualPromotions.splice(manualPromotions.indexOf(promotionToDelete), 1); } receipt.calculateReceipt(); receipt.set('undo', null); receipt.set('multipleUndo', null); } | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2021-05-28 08:12 | guillermogil | New Issue | |||
| 2021-05-28 08:12 | guillermogil | Assigned To | => Retail | ||
| 2021-05-28 08:12 | guillermogil | Resolution time | => 1623708000 | ||
| 2021-05-28 08:12 | guillermogil | Triggers an Emergency Pack | => No | ||
| 2021-05-28 08:19 | guillermogil | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=22624#r22624 | ||
| 2021-05-28 08:19 | guillermogil | Proposed Solution updated | |||
| 2021-06-06 23:13 | rqueralta | Assigned To | Retail => rqueralta | ||
| 2021-06-06 23:13 | rqueralta | Status | new => scheduled | ||
| 2021-06-09 20:23 | hgbot | Note Added: 0129288 | |||
| 2021-06-10 09:45 | hgbot | Resolution | open => fixed | ||
| 2021-06-10 09:45 | hgbot | Status | scheduled => closed | ||
| 2021-06-10 09:45 | hgbot | Fixed in Version | => RR21Q3 | ||
| 2021-06-10 09:45 | hgbot | Note Added: 0129309 | |||
| 2021-06-10 09:45 | hgbot | Note Added: 0129310 | |||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||