0046799: Datepicker Enhancement

Description

Following are some enhancement to be applied for new date picker,

1. The calendar icon is different to the one used in figma

2. Make sense to change all the pickers to use the new one and remove the old "BaseFormDate".
If we see that BaseFormDate does not give us any feature which we can't cover with the new component, I think it makes all the sense to replace its usages and finally remove it.

3. Open new customer popup
put focus on birthdate field which is empty
Input changes to edit mode -> OK
Press calendar icon -> calendar is opened but field looks red (error) behind the calendar
Select a date in the calendar -> date is correctly applied to the input but still error is shown
Is required to put the focus outside the input to make the error disappear

4. When focus is in date input and clear button is pressed it does not work.
It must be pressed twice.
It seems that first time blur event of input is triggered and then in the second click the clear action is executed

5. If you start to write the date directly in the input, component shows the expected format.
Would be great to show it in that way when input is empty

6. In figma a message with the expected format is shown below the field

7. We have different test functions that helps to work with form components: (fillDate, selectComboBoxOption, etc.).
I think it would be nice to have a test funcion (called pickDate for example) which allows to pick a date from a BaseFormDatePicker in a test.
Currently already doing it in test, so that code into a file and export the function (similar to what we are doing in the other functions I've mentioned) so it can be reused in other tests.

8. When datepicker is read only the calendar icon should not be shown

9. Datepicker value is not being validated at all.
For eg: It allows 24 in month and 45 for day.

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	feature request	0046433		closed	prakashmurugesan88	Datepicker Enhancement
related to	backport	0046800	TAP	closed	caristu	Date picker should be translatable

Notes
(0128552) caristu (manager) 2021-05-24 10:39 edited on: 2021-05-24 10:40	MRs: - core2: https://gitlab.com/obcustomers/AGAP/org.openbravo.core2/-/merge_requests/11 [^] - pos2: https://gitlab.com/obcustomers/AGAP/org.openbravo.pos2/-/merge_requests/25 [^]

Issue History
Date Modified	Username	Field	Change
2021-05-22 09:32	caristu	New Issue
2021-05-22 09:32	caristu	Assigned To	=> caristu
2021-05-22 09:32	caristu	Triggers an Emergency Pack	=> No
2021-05-22 09:32	caristu	Issue generated from	0046433
2021-05-22 09:32	caristu	Relationship added	related to 0046433
2021-05-22 09:32	caristu	Target Version	=> TAP
2021-05-24 09:11	guilleaer	Status	new => scheduled
2021-05-24 09:12	guilleaer	Resolution time	=> 1622152800
2021-05-24 10:39	caristu	Relationship added	related to 0046800
2021-05-24 10:40	caristu	Note Added: 0128552
2021-05-24 10:40	caristu	Status	scheduled => resolved
2021-05-24 10:40	caristu	Fixed in Version	=> TAP
2021-05-24 10:40	caristu	Resolution	open => fixed
2021-05-24 10:40	caristu	Note Edited: 0128552	View Revisions
2021-05-24 10:40	caristu	Review Assigned To	=> guilleaer
2021-05-24 10:40	caristu	Status	resolved => closed