Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0046433 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] POS | minor | have not tried | 2021-04-30 08:30 | 2021-05-22 09:32 | |||
| Reporter | prakashmurugesan88 | View Status | public | |||||
| Assigned To | prakashmurugesan88 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0046433: Datepicker Enhancement | |||||||
| Description | Following are some enhancement to be applied for new date picker, 1. The calendar icon is different to the one used in figma 2. Make sense to change all the pickers to use the new one and remove the old "BaseFormDate". If we see that BaseFormDate does not give us any feature which we can't cover with the new component, I think it makes all the sense to replace its usages and finally remove it. 3. Open new customer popup put focus on birthdate field which is empty Input changes to edit mode -> OK Press calendar icon -> calendar is opened but field looks red (error) behind the calendar Select a date in the calendar -> date is correctly applied to the input but still error is shown Is required to put the focus outside the input to make the error disappear 4. When focus is in date input and clear button is pressed it does not work. It must be pressed twice. It seems that first time blur event of input is triggered and then in the second click the clear action is executed 5. If you start to write the date directly in the input, component shows the expected format. Would be great to show it in that way when input is empty 6. In figma a message with the expected format is shown below the field 7. We have different test functions that helps to work with form components: (fillDate, selectComboBoxOption, etc.). I think it would be nice to have a test funcion (called pickDate for example) which allows to pick a date from a BaseFormDatePicker in a test. Currently already doing it in test, so that code into a file and export the function (similar to what we are doing in the other functions I've mentioned) so it can be reused in other tests. 8. When datepicker is read only the calendar icon should not be shown 9. Datepicker value is not being validated at all. For eg: It allows 24 in month and 45 for day. | |||||||
| Steps To Reproduce | NA | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0127867) hgbot (developer) 2021-05-06 19:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/493 [^] |
|
(0127868) hgbot (developer) 2021-05-06 19:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/440 [^] |
|
(0127869) hgbot (developer) 2021-05-06 19:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/3 [^] |
|
(0128001) hgbot (developer) 2021-05-11 17:35 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 6270adce665b081cfcd4757882a5fa7c062c8ddc Author: Prakash M <prakash@qualiantech.com> Date: 2021-05-11T21:03:51+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6270adce665b081cfcd4757882a5fa7c062c8ddc [^] Fixed BUG-46433: Datepicker Enhancement --- A web-jspack/org.openbravo.core2/src/assets/icons/calendar.svg A web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/__test__/selectBaseFormDatePicker.js M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.core2/src/assets/style/iconography.scss M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.scss M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/__test__/BaseFormDatePicker.test.jsx M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/stories/BaseFormDatePicker.stories.jsx M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx M web-jspack/org.openbravo.core2/src/components/Form/FormHandler.js M web-jspack/org.openbravo.core2/src/components/Form/stories/ConfigurableForm.stories.jsx M web-jspack/org.openbravo.core2/src/core/I18N.js M web-jspack/org.openbravo.core2/src/ob-init.js R web-jspack/org.openbravo.core2/src/components/BaseFormDate/BaseFormDate.jsx R web-jspack/org.openbravo.core2/src/components/BaseFormDate/BaseFormDate.scss R web-jspack/org.openbravo.core2/src/components/BaseFormDate/__test__/BaseFormDate.test.jsx R web-jspack/org.openbravo.core2/src/components/BaseFormDate/index.js R web-jspack/org.openbravo.core2/src/components/BaseFormDate/stories/BaseFormDate.stories.jsx --- |
|
(0128002) hgbot (developer) 2021-05-11 17:39 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/440 [^] |
|
(0128003) hgbot (developer) 2021-05-11 17:39 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0b20a53c4ffba5217b2c00d19817f03ae2a06ae8 Author: Prakash M <prakash@qualiantech.com> Date: 2021-05-11T21:07:47+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0b20a53c4ffba5217b2c00d19817f03ae2a06ae8 [^] Related to Issue-46433: Removed BaseFormDate usage and replaced with new DatePicker component --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/__test__/CustomerForm.test.jsx M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/__test__/CustomerSelector.test.jsx --- |
|
(0128004) hgbot (developer) 2021-05-11 17:43 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey [^] Changeset: 89a5fbd17177a3de5f9b4e4080f7afb784bb68ff Author: Prakash M <prakash@qualiantech.com> Date: 2021-05-11T21:11:56+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/commit/89a5fbd17177a3de5f9b4e4080f7afb784bb68ff [^] Related to ISSUE-46433: Removed BaseFormDate usage --- M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurveyStoriesUtils.jsx --- |
|
(0128005) hgbot (developer) 2021-05-11 17:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/3 [^] |
|
(0128006) hgbot (developer) 2021-05-11 17:50 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/493 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-04-30 08:30 | prakashmurugesan88 | New Issue | |
| 2021-04-30 08:30 | prakashmurugesan88 | Assigned To | => prakashmurugesan88 |
| 2021-04-30 08:30 | prakashmurugesan88 | OBNetwork customer | => OBPS |
| 2021-04-30 08:30 | prakashmurugesan88 | Triggers an Emergency Pack | => No |
| 2021-04-30 08:32 | prakashmurugesan88 | Description Updated | View Revisions |
| 2021-04-30 08:32 | prakashmurugesan88 | Status | new => scheduled |
| 2021-04-30 08:33 | prakashmurugesan88 | Status | scheduled => feedback |
| 2021-04-30 08:34 | prakashmurugesan88 | Status | feedback => scheduled |
| 2021-04-30 08:38 | prakashmurugesan88 | Description Updated | View Revisions |
| 2021-04-30 11:13 | guilleaer | OBNetwork customer | OBPS => No |
| 2021-05-02 21:22 | guilleaer | Description Updated | View Revisions |
| 2021-05-05 07:51 | prakashmurugesan88 | Description Updated | View Revisions |
| 2021-05-05 07:55 | prakashmurugesan88 | Description Updated | View Revisions |
| 2021-05-06 19:45 | hgbot | Merge Request Status | => open |
| 2021-05-06 19:45 | hgbot | Note Added: 0127867 | |
| 2021-05-06 19:45 | hgbot | Note Added: 0127868 | |
| 2021-05-06 19:45 | hgbot | Note Added: 0127869 | |
| 2021-05-07 11:14 | hgbot | Merge Request Status | open => approved |
| 2021-05-11 17:35 | hgbot | Resolution | open => fixed |
| 2021-05-11 17:35 | hgbot | Status | scheduled => closed |
| 2021-05-11 17:35 | hgbot | Note Added: 0128001 | |
| 2021-05-11 17:39 | hgbot | Note Added: 0128002 | |
| 2021-05-11 17:39 | hgbot | Note Added: 0128003 | |
| 2021-05-11 17:43 | hgbot | Note Added: 0128004 | |
| 2021-05-11 17:43 | hgbot | Note Added: 0128005 | |
| 2021-05-11 17:50 | hgbot | Note Added: 0128006 | |
| 2021-05-22 09:32 | caristu | Issue cloned | 0046799 |
| 2021-05-22 09:32 | caristu | Relationship added | related to 0046799 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |