Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046676
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POScriticalsometimes2021-05-14 09:532021-05-26 13:03
Reportertimothee_catteeuwView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046676: JIRA 1866 - POP - ISSUE about around when splitting a ticket in 2 or 3 equal parts

DescriptionWhen selecting these items :BEEF BURGER BACON NEW / DOUBLE TENNESSEE ROSTI BURGER / CHARLIES CASSIS MENTHE 33CL BT/ LIPTON GREEN CTRON 50 CL PET

Total = 22.45 €

After paying, I try to generate a POP in 2 equals parts, the amount for each POP is KO.

Cf. attached image

In that case, 1 POP has to be 11,22, the other 11,23.

It is the same when I want to split in 3 equals parts :

Cf. the second image

The total amount is 22,44 instead of 22,45 €.
Steps To ReproduceCf. description
TagsNo tags attached.
Attached Fileszip file icon FLUN-1866_attachments.zip [^] (137,419 bytes) 2021-05-14 09:53

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0046652 closedjavierRodriguez JIRA 1865 - POP - Issue about arounds 
depends on backport 0046689TAP closedjavierRodriguez JIRA 1866 - POP - ISSUE about around when splitting a ticket in 2 or 3 equal parts 

-  Notes
(0128547)
hgbot (developer)
2021-05-24 09:43

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/482 [^]
(0128649)
hgbot (developer)
2021-05-26 13:03

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fb971312d7a389b5dfefa1c57f5a1f1a0456fd4d
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fb971312d7a389b5dfefa1c57f5a1f1a0456fd4d [^]

Fixed ISSUE-46676: Rounding pop amount values properly

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/GeneratePopDivideEqually.js
---
(0128650)
hgbot (developer)
2021-05-26 13:03

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1a507ff723d23672c9b22b69298af7df862a6c7e
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1a507ff723d23672c9b22b69298af7df862a6c7e [^]

Related to ISSUE-46676: check if the amount fix with the final ticket gross in every pop type

---
A web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/CheckRoundingPops.js
A web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/PopTypes.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/ProofOfPurchase.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/__test__/AddNewProofOfPurchaseUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/actions/AddNewProofOfPurchaseDivide.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/actions/AddNewProofOfPurchaseFill.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/AddNewProofOfPurchase.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/GeneratePopDivideEqually.js
---
(0128651)
hgbot (developer)
2021-05-26 13:03

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 42a17871895e679195a3d2c2093504245451afba
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/42a17871895e679195a3d2c2093504245451afba [^]

Related to ISSUE-46676: Remove useless variable in generatePopDivideEqually

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/GeneratePopDivideEqually.js
---
(0128652)
hgbot (developer)
2021-05-26 13:03

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/482 [^]
(0128653)
hgbot (developer)
2021-05-26 13:03

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 491dae833c2c137e212f9b01eda1e6b9f1d01a20
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/491dae833c2c137e212f9b01eda1e6b9f1d01a20 [^]

Related to ISSUE-46676: Include new tests to check rounding functionality

---
A web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/__test__/CheckRoundingPops.test.js
A web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/__test__/mock/mockPop.js
---
(0128654)
hgbot (developer)
2021-05-26 13:03

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 575e35a8fb9e440ac6ad4bcf5882476fb1113e69
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/575e35a8fb9e440ac6ad4bcf5882476fb1113e69 [^]

Related to ISSUE-46676: Fix rounding in fill in amount pops

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/GeneratePopFillInAmount.js
---
(0128655)
hgbot (developer)
2021-05-26 13:03

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 883f714f966b1b57e6e5affdd95736753d6c6ae1
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/883f714f966b1b57e6e5affdd95736753d6c6ae1 [^]

Related to ISSUE-46676: Clean mock ticket in pop tests

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/__test__/mock/mockPop.js
---
(0128656)
hgbot (developer)
2021-05-26 13:03

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 06eea3f7de7881ce29fd13fd4b64628dffeed339
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-26T13:01:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/06eea3f7de7881ce29fd13fd4b64628dffeed339 [^]

Related to ISSUE-46676: Replace forEach by map

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPurchase/utils/CheckRoundingPops.js
---

- Issue History
Date Modified Username Field Change
2021-05-14 09:53 timothee_catteeuw New Issue
2021-05-14 09:53 timothee_catteeuw Assigned To => Retail
2021-05-14 09:53 timothee_catteeuw File Added: FLUN-1866_attachments.zip
2021-05-14 09:53 timothee_catteeuw Triggers an Emergency Pack => No
2021-05-17 12:21 guilleaer Resolution time => 1621548000
2021-05-17 12:21 guilleaer Severity major => critical
2021-05-17 12:21 guilleaer Relationship added related to 0046652
2021-05-17 12:22 guilleaer Status new => scheduled
2021-05-17 12:22 guilleaer Status scheduled => acknowledged
2021-05-18 14:30 javierRodriguez Status acknowledged => scheduled
2021-05-18 14:30 javierRodriguez Assigned To Retail => javierRodriguez
2021-05-24 09:43 hgbot Note Added: 0128547
2021-05-26 13:03 hgbot Resolution open => fixed
2021-05-26 13:03 hgbot Status scheduled => closed
2021-05-26 13:03 hgbot Note Added: 0128649
2021-05-26 13:03 hgbot Note Added: 0128650
2021-05-26 13:03 hgbot Note Added: 0128651
2021-05-26 13:03 hgbot Note Added: 0128652
2021-05-26 13:03 hgbot Note Added: 0128653
2021-05-26 13:03 hgbot Note Added: 0128654
2021-05-26 13:03 hgbot Note Added: 0128655
2021-05-26 13:03 hgbot Note Added: 0128656

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker