0046586: 0045829: Display and usage of gift cards / gift certificates and credit notes

Description

Following the resolution of 0045829. Still not correct.

That's the points discussed with Antonio :

"- First, we need to rename the preference "Web POS Forbid use Gift Card with different gift card owner" to "WebPOS Customer using a gift card must be the one who bought it", just to explain better what the preference actually does. Its behaviour should not be changed."
=> Done. I'm OK, no problem with that.

"- Then, we need to define a new preference: "Web POS Only show gift cards owned or bought by current customer". The default value for this preference should be "N", and if it is "N" the behaviour should be the current one. However, if it is set to "Y", then the selector should automatically show only gift cards for which either the business partner field, or the owner, corresponds to the currently selected business partner."
=> Partially done.Ok the preference is created and works somehow BUT :
-> The preference seems only apply in MENU
-> GIFT / CREDIT NOTE :
-> If a customer is assigned to the receipt, his cards are well retrieved but only those created in the store
=> Should be GIFT CARDS/ CREDIT NOTES / GIFT CERTIFICATES of the customer assigned-> The preference seems to not apply correctly on Payment methods

See the current behavior : https://drive.google.com/file/d/1clzCeDfHKSQ-4T1CH6CpuaVr-2Z8qOMW/view?usp=sharing [^]

"And apart from this, we should add the preference "Web POS - customer restriction for gift cards list display" as suggested by the issue reported in Mantis."
=> This new preference doesn't exists meaning :
-> If I don't select any customer (keeping the anonymous customer) :
-> In MENU -> GIFT / CREDIT NOTE, I still have all the card just clicking on the magnifier
-> In payment method GIFT CARDS/ CREDIT NOTES / GIFT CERTIFICATES, I still have all the card just clicking on the magnifier

See the current behavior : https://drive.google.com/file/d/1rOBhcAzcTqEBO4G2tbF3Cgy6hwcDacdq/view?usp=sharing [^]

Steps To Reproduce

see videos in description

Proposed Solution

Expected behavior :
At the end, with the good preference values, that's what should happens :
For instance, I have 3 giftcards / credit notes / gift certificates :
- 123 : purchased by Raphael wicher
- 456 : purchased by the anonymous customer and owned by it (or null)
- 789 : owned by Raphael wicher

1rst case : Raphael wicher is assigned to the ticket
- I click on the magnifier without putting any code : I have 123 and 789 in the list view
- I put the code 456 and only then I click on the magnifier : I can see the card 456 and use it

2nd case : Antonio Moreno is assigned to the ticket
- I click on the magnifier without putting any code : I have nothing in the list view
- I put the code 456 or 789 for instance and only then I click on the magnifier : I can see the card and use it

3rd case : the anonymous customer is assigned to the ticket
- I click on the magnifier without putting any code : I have nothing in the list view
- I put the code 456 or 789 for instance and only then I click on the magnifier : I can see the card and use it

We need it in :
- Norauto : PR20Q3.1
- Weldom : PR20Q3.4

Tags

NOR

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0047748	pi	closed	ranjith_qualiantech_com	Preference GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer is not getting properly
causes	defect	0048479		closed	radhakrishnan	JS Error when applying Advanced Filters in Reimburse under Cash management

Notes
(0128518) hgbot (developer) 2021-05-21 21:48	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/62 [^]

(0128979) hgbot (developer) 2021-06-03 08:04	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: d4eecbcea94dc887520372f3c6576e9d830e9485 Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-06-03T06:04:10+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/d4eecbcea94dc887520372f3c6576e9d830e9485 [^] Fixed BUG-46586: Added new preference to allow or not see the gift cards list if anonymous customer is assigned to the ticket --- M src-db/database/sourcedata/AD_REF_LIST.xml M web/org.openbravo.retail.giftcards/js/components/GiftCardDialog.js M web/org.openbravo.retail.giftcards/js/components/GiftCardSearchDialog.js ---

(0128980) hgbot (developer) 2021-06-03 08:04	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/62 [^]

Issue History
Date Modified	Username	Field	Change
2021-05-07 13:52	wicherr	New Issue
2021-05-07 13:52	wicherr	Assigned To	=> rqueralta
2021-05-07 13:52	wicherr	OBNetwork customer	=> No
2021-05-07 13:52	wicherr	Triggers an Emergency Pack	=> No
2021-05-07 13:53	wicherr	Tag Attached: NOR
2021-05-21 21:48	hgbot	Merge Request Status	=> open
2021-05-21 21:48	hgbot	Note Added: 0128518
2021-06-03 08:04	hgbot	Merge Request Status	open => approved
2021-06-03 08:04	hgbot	Resolution	open => fixed
2021-06-03 08:04	hgbot	Status	new => closed
2021-06-03 08:04	hgbot	Note Added: 0128979
2021-06-03 08:04	hgbot	Note Added: 0128980
2021-09-23 14:56	rafaroda	Relationship added	related to 0047748
2022-01-25 10:47	ranjith_qualiantech_com	Relationship added	causes 0048479