Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0047748

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Gift cards and gift vouchers

major

always

2021-09-23 11:49

2021-10-04 06:59

Reporter

jetxarri

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

pi

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0047748: Preference GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer is not getting properly

Description

Preference GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer is not getting properly in JAVA code.

The code is not specifying the client, org and role. Due to that, if the user configures this preference at client level is not going to work

Steps To Reproduce

-Create a pref at client level with property "Web POS Show gift cards owned or bought by current customer"
-Login into Web POS
-Select a BP
-Go to details view
-Press Gift Cards/Voucher

Verify that the value of above pref is false and bp gift cards are not loaded.

Proposed Solution

Attached a diff

Tags

pref.diff [^] (983 bytes) 2021-09-23 11:49 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/giftcards/FindGiftCards.java b/src/org/openbravo/retail/giftcards/FindGiftCards.java
index fddbeb9..6d7c93d 100644
--- a/src/org/openbravo/retail/giftcards/FindGiftCards.java
+++ b/src/org/openbravo/retail/giftcards/FindGiftCards.java
@@ -98,9 +98,11 @@ public class FindGiftCards extends ProcessHQLQuery {
     boolean isFilterdBySearchKey = false;
     boolean showGiftCardOwned = false;
     try {
+      OBContext context = OBContext.getOBContext();
       showGiftCardOwned = "Y"
           .equals(Preferences.getPreferenceValue("GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer",
-              true, null, null, OBContext.getOBContext().getUser(), null, null));
+              true, context.getCurrentClient(), context.getCurrentOrganization(),
+              OBContext.getOBContext().getUser(), context.getRole(), null));
     } catch (PropertyException e) {
     }
     JSONArray remoteFilters = jsonsent.getJSONArray("remoteFilters");

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

RR20Q3.1

closed

0045829: Display and usage of gift cards / gift certificates and credit notes

Notes
(0132072) hgbot (developer) 2021-09-30 07:07	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/93 [^]

(0132111) hgbot (developer) 2021-10-04 06:59	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/93 [^]

(0132112) hgbot (developer) 2021-10-04 06:59	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: e92fcce6b477f8c467332f2e6bba7e0ece4d1418 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-10-04T04:59:32+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/e92fcce6b477f8c467332f2e6bba7e0ece4d1418 [^] Fixed ISSUE-47748: Added Preference visibility when finding giftcards * Added visibility (client, org, role) for Pref. GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer --- M src/org/openbravo/retail/giftcards/FindGiftCards.java ---

Issue History
Date Modified	Username	Field	Change
2021-09-23 11:49	jetxarri	New Issue
2021-09-23 11:49	jetxarri	Assigned To	=> Retail
2021-09-23 11:49	jetxarri	File Added: pref.diff
2021-09-23 11:49	jetxarri	OBNetwork customer	=> OBPS
2021-09-23 11:49	jetxarri	Triggers an Emergency Pack	=> No
2021-09-23 14:55	rafaroda	Tag Attached: NOR
2021-09-23 14:56	rafaroda	Relationship added	related to 0046586
2021-09-29 14:13	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2021-09-30 07:07	hgbot	Merge Request Status	=> open
2021-09-30 07:07	hgbot	Note Added: 0132072
2021-10-04 06:59	hgbot	Merge Request Status	open => approved
2021-10-04 06:59	hgbot	Resolution	open => fixed
2021-10-04 06:59	hgbot	Note Added: 0132111
2021-10-04 06:59	hgbot	Status	new => closed
2021-10-04 06:59	hgbot	Note Added: 0132112

Copyright © 2000 - 2009 MantisBT Group