Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046529
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2021-05-06 08:382021-05-11 08:06
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046529: Cancel and replace fails when used from ExternalOrderLoader

DescriptionExternalOrderLoader can be used to Cancel&Replace an order after it was implemented in the following issue:

https://issues.openbravo.com/view.php?id=45423 [^]

However, it currently fails if used because of an "OutDatedDataChangeException" error. This error happens because in C&R the canceledorder needs to be specified, but then the concurrency modification check is performed. This problem is avoided in the Cancel order flow because there the check is disabled. The same thing should be done for the C&R flow
Steps To ReproduceDownload the postman from the Retail API repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json [^]

Execute the "Import Order - Order with consistent id (to C&R later)" request (in Order folder). An order will be created in the backend.
Execute the "Import Order - Order cancel and replace" request (in Order folder). Verify that it fails with OutDatedDataChangeException exception.
Proposed SolutionThe disableConcurrencyCheck method should also be called in the C&R flow.
TagsNo tags attached.
Attached Filespatch file icon fixIssue46529.patch [^] (865 bytes) 2021-05-06 08:40 [Show Content]
patch file icon fixIssue46529-2.patch [^] (2,080 bytes) 2021-05-10 18:14 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0045423 closedjavietxe Add Cancel and replace in ExternalOrderLoader 
depends on backport 0046531RR21Q2 closedranjith_qualiantech_com Cancel and replace fails when used from ExternalOrderLoader 
depends on backport 0046532RR21Q1.2 closedranjith_qualiantech_com Cancel and replace fails when used from ExternalOrderLoader 

-  Notes
(0127910)
hgbot (developer)
2021-05-10 07:15

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/403 [^]
(0127918)
hgbot (developer)
2021-05-10 07:39

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/403 [^]
(0127919)
hgbot (developer)
2021-05-10 07:39

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 92793632a68ca5c45566d0f890ce66cc7a0adeae
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-10T05:39:49+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/92793632a68ca5c45566d0f890ce66cc7a0adeae [^]

Fixed ISSUE-46529: Transform CR Details in ExternalOrderLoader

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0127965)
marvintm (manager)
2021-05-10 18:12

Instead, it would be better if canceledorder would not be required at all. This would make the API easier to use.
(0127970)
hgbot (developer)
2021-05-11 07:52

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/408 [^]
(0127971)
hgbot (developer)
2021-05-11 08:06

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/408 [^]
(0127972)
hgbot (developer)
2021-05-11 08:06

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 798d134a60376201f0d4907ef918f06cc1e5ce60
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-11T11:19:15+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/798d134a60376201f0d4907ef918f06cc1e5ce60 [^]

Fixed ISSUE-46529: Skip Last Modification validation when doing CR from EOL

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2021-05-06 08:38 marvintm New Issue
2021-05-06 08:38 marvintm Assigned To => Retail
2021-05-06 08:38 marvintm Triggers an Emergency Pack => No
2021-05-06 08:39 marvintm Resolution time => 1621461600
2021-05-06 08:39 marvintm Relationship added related to 0045423
2021-05-06 08:39 marvintm Status new => scheduled
2021-05-06 08:40 marvintm File Added: fixIssue46529.patch
2021-05-06 08:42 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-05-10 07:15 hgbot Note Added: 0127910
2021-05-10 07:39 hgbot Resolution open => fixed
2021-05-10 07:39 hgbot Status scheduled => closed
2021-05-10 07:39 hgbot Note Added: 0127918
2021-05-10 07:39 hgbot Fixed in Version => RR21Q3
2021-05-10 07:39 hgbot Note Added: 0127919
2021-05-10 18:12 marvintm Note Added: 0127965
2021-05-10 18:12 marvintm Status closed => new
2021-05-10 18:12 marvintm Resolution fixed => open
2021-05-10 18:12 marvintm Fixed in Version RR21Q3 =>
2021-05-10 18:14 marvintm File Added: fixIssue46529-2.patch
2021-05-11 07:52 hgbot Note Added: 0127970
2021-05-11 08:06 hgbot Note Added: 0127971
2021-05-11 08:06 hgbot Resolution open => fixed
2021-05-11 08:06 hgbot Status new => closed
2021-05-11 08:06 hgbot Fixed in Version => RR21Q3
2021-05-11 08:06 hgbot Note Added: 0127972


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker