Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046529Retail ModulesWeb POSpublic2021-05-06 08:382021-05-11 08:06
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046529: Cancel and replace fails when used from ExternalOrderLoader
DescriptionExternalOrderLoader can be used to Cancel&Replace an order after it was implemented in the following issue:

https://issues.openbravo.com/view.php?id=45423 [^]

However, it currently fails if used because of an "OutDatedDataChangeException" error. This error happens because in C&R the canceledorder needs to be specified, but then the concurrency modification check is performed. This problem is avoided in the Cancel order flow because there the check is disabled. The same thing should be done for the C&R flow
Steps To ReproduceDownload the postman from the Retail API repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json [^]

Execute the "Import Order - Order with consistent id (to C&R later)" request (in Order folder). An order will be created in the backend.
Execute the "Import Order - Order cancel and replace" request (in Order folder). Verify that it fails with OutDatedDataChangeException exception.
Proposed SolutionThe disableConcurrencyCheck method should also be called in the C&R flow.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0045423 closed javietxe Add Cancel and replace in ExternalOrderLoader 
depends on backport 0046531RR21Q2 closed ranjith_qualiantech_com Cancel and replace fails when used from ExternalOrderLoader 
depends on backport 0046532RR21Q1.2 closed ranjith_qualiantech_com Cancel and replace fails when used from ExternalOrderLoader 
Attached Filespatch fixIssue46529.patch (865) 2021-05-06 08:40
https://issues.openbravo.com/file_download.php?file_id=15656&type=bug
patch fixIssue46529-2.patch (2,080) 2021-05-10 18:14
https://issues.openbravo.com/file_download.php?file_id=15684&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-05-06 08:38marvintmNew Issue
2021-05-06 08:38marvintmAssigned To => Retail
2021-05-06 08:38marvintmOBNetwork customer => No
2021-05-06 08:38marvintmTriggers an Emergency Pack => No
2021-05-06 08:39marvintmOBNetwork customerNo => Gold
2021-05-06 08:39marvintmResolution time => 1621461600
2021-05-06 08:39marvintmRelationship addedrelated to 0045423
2021-05-06 08:39marvintmStatusnew => scheduled
2021-05-06 08:40marvintmFile Added: fixIssue46529.patch
2021-05-06 08:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-05-10 07:15hgbotMerge Request Status => open
2021-05-10 07:15hgbotNote Added: 0127910
2021-05-10 07:39hgbotMerge Request Statusopen => approved
2021-05-10 07:39hgbotResolutionopen => fixed
2021-05-10 07:39hgbotStatusscheduled => closed
2021-05-10 07:39hgbotNote Added: 0127918
2021-05-10 07:39hgbotFixed in Version => RR21Q3
2021-05-10 07:39hgbotNote Added: 0127919
2021-05-10 18:12marvintmNote Added: 0127965
2021-05-10 18:12marvintmStatusclosed => new
2021-05-10 18:12marvintmResolutionfixed => open
2021-05-10 18:12marvintmFixed in VersionRR21Q3 =>
2021-05-10 18:14marvintmFile Added: fixIssue46529-2.patch
2021-05-11 07:52hgbotNote Added: 0127970
2021-05-11 08:06hgbotNote Added: 0127971
2021-05-11 08:06hgbotResolutionopen => fixed
2021-05-11 08:06hgbotStatusnew => closed
2021-05-11 08:06hgbotFixed in Version => RR21Q3
2021-05-11 08:06hgbotNote Added: 0127972

Notes
(0127910)
hgbot   
2021-05-10 07:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/403 [^]
(0127918)
hgbot   
2021-05-10 07:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/403 [^]
(0127919)
hgbot   
2021-05-10 07:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 92793632a68ca5c45566d0f890ce66cc7a0adeae
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-10T05:39:49+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/92793632a68ca5c45566d0f890ce66cc7a0adeae [^]

Fixed ISSUE-46529: Transform CR Details in ExternalOrderLoader

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0127965)
marvintm   
2021-05-10 18:12   
Instead, it would be better if canceledorder would not be required at all. This would make the API easier to use.
(0127970)
hgbot   
2021-05-11 07:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/408 [^]
(0127971)
hgbot   
2021-05-11 08:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/408 [^]
(0127972)
hgbot   
2021-05-11 08:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 798d134a60376201f0d4907ef918f06cc1e5ce60
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-11T11:19:15+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/798d134a60376201f0d4907ef918f06cc1e5ce60 [^]

Fixed ISSUE-46529: Skip Last Modification validation when doing CR from EOL

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
---