Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046531
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2021-05-06 08:382021-05-11 08:23
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR21Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR21Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046531: Cancel and replace fails when used from ExternalOrderLoader

DescriptionExternalOrderLoader can be used to Cancel&Replace an order after it was implemented in the following issue:

https://issues.openbravo.com/view.php?id=45423 [^]

However, it currently fails if used because of an "OutDatedDataChangeException" error. This error happens because in C&R the canceledorder needs to be specified, but then the concurrency modification check is performed. This problem is avoided in the Cancel order flow because there the check is disabled. The same thing should be done for the C&R flow
Steps To ReproduceDownload the postman from the Retail API repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json [^]

Execute the "Import Order - Order with consistent id (to C&R later)" request (in Order folder). An order will be created in the backend.
Execute the "Import Order - Order cancel and replace" request (in Order folder). Verify that it fails with OutDatedDataChangeException exception.
Proposed SolutionThe disableConcurrencyCheck method should also be called in the C&R flow.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0046529 closedranjith_qualiantech_com Cancel and replace fails when used from ExternalOrderLoader 

-  Notes
(0127948)
hgbot (developer)
2021-05-10 15:27

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/406 [^]
(0127959)
hgbot (developer)
2021-05-10 16:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/406 [^]
(0127960)
hgbot (developer)
2021-05-10 16:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b3522e9d9d5c3af9d673ef03bf6aa54bc059d0f6
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-10T18:51:11+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b3522e9d9d5c3af9d673ef03bf6aa54bc059d0f6 [^]

Fixed ISSUE-46531: Transform CR Details in ExternalOrderLoader

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0127974)
hgbot (developer)
2021-05-11 08:14

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/410 [^]
(0127975)
hgbot (developer)
2021-05-11 08:23

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/410 [^]
(0127976)
hgbot (developer)
2021-05-11 08:23

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8e146988f7942fcf783b3413f4fe539ae2d232e4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-11T11:42:09+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8e146988f7942fcf783b3413f4fe539ae2d232e4 [^]

Fixed ISSUE-46531: Skip Last Modification validation when doing CR from EOL

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2021-05-06 08:39 marvintm Type defect => backport
2021-05-06 08:39 marvintm Target Version => RR21Q2
2021-05-06 11:54 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-05-10 15:27 hgbot Merge Request Status => open
2021-05-10 15:27 hgbot Note Added: 0127948
2021-05-10 16:10 hgbot Merge Request Status open => approved
2021-05-10 16:10 hgbot Resolution open => fixed
2021-05-10 16:10 hgbot Status scheduled => closed
2021-05-10 16:10 hgbot Fixed in Version => RR21Q2
2021-05-10 16:10 hgbot Note Added: 0127959
2021-05-10 16:10 hgbot Note Added: 0127960
2021-05-10 18:25 marvintm Status closed => new
2021-05-10 18:25 marvintm Resolution fixed => open
2021-05-10 18:25 marvintm Fixed in Version RR21Q2 =>
2021-05-11 08:14 hgbot Note Added: 0127974
2021-05-11 08:21 ranjith_qualiantech_com Status new => scheduled
2021-05-11 08:23 hgbot Resolution open => fixed
2021-05-11 08:23 hgbot Status scheduled => closed
2021-05-11 08:23 hgbot Note Added: 0127975
2021-05-11 08:23 hgbot Fixed in Version => RR21Q2
2021-05-11 08:23 hgbot Note Added: 0127976

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker