Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046378
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2021-04-28 04:512021-05-17 08:21
Reportercollazoandy4View Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046378: Check barcode duplicity in Digital Coupons

DescriptionTwo digital coupons can have the same barcode and a wrong accounting information can be defined
Steps To Reproduce- Log-in in the POS (YS-11 livebuilds with modules)
- Add a product
- Go to the payment tab
- Add a "Digital Coupon" as payment
- Fill the coupon data with an amount less than the pending amount and a barcode of 50
- Add another coupon with the same barcode value (50) with an amount equal to the pending amount
- Check the second coupon can be created without any issue
Proposed SolutionAdd a new preference to check the barcode duplicity and a new hook in org.openbravo.retail.chequecadeau module to check if the same barcode exists in a coupon
TagsNo tags attached.
Attached Filespatch file icon 1. added validation.patch [^] (11,043 bytes) 2021-04-28 04:55 [Show Content]
patch file icon 2. improve message.patch [^] (2,061 bytes) 2021-04-28 04:55 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0047175 closedrqueralta Take into account draft tickets when barcode is checked for duplicity in Digital Coupons 
related to defect 0047367 closedrqueralta Do not check barcode duplicity in digital coupons if barcode is empty 
related to defect 0047459 closedrqueralta Check issuing company in Digital Coupons 

-  Notes
(0128044)
hgbot (developer)
2021-05-12 16:01

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/5 [^]
(0128087)
hgbot (developer)
2021-05-14 08:06

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau [^]
Changeset: 546d16a80854b2b9007b169d4903a9da0cb812bf
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-05-11T17:41:59-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/commit/546d16a80854b2b9007b169d4903a9da0cb812bf [^]

Fixed BUG-46378: Added a new preference to check the barcode duplicity and a new hook in org.openbravo.retail.chequecadeau module to check if the same barcode exists in a coupon

---
A src-db/database/sourcedata/AD_REF_LIST.xml
A src/org/openbravo/retail/chequecadeau/hooks/ValidateChequeCadeauBarcode.java
A web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/chequecadeau/ChequeCadeauComponentProvider.java
---
(0128088)
hgbot (developer)
2021-05-14 08:06

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/5 [^]
(0128133)
hgbot (developer)
2021-05-14 21:31

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/6 [^]
(0128135)
hgbot (developer)
2021-05-14 21:31

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/6 [^]
(0128185)
marvintm (manager)
2021-05-17 08:21

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau [^] [^]
Changeset: dd9f40b16d5822791de18d91ee5095d54464ce67
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-05-14T15:29:23-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/commit/dd9f40b16d5822791de18d91ee5095d54464ce67 [^] [^]

Fixed BUG-46637: Removed OB definition

---
M web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
---

- Issue History
Date Modified Username Field Change
2021-04-28 04:51 collazoandy4 New Issue
2021-04-28 04:51 collazoandy4 Assigned To => Retail
2021-04-28 04:51 collazoandy4 Resolution time => 1620684000
2021-04-28 04:51 collazoandy4 Triggers an Emergency Pack => No
2021-04-28 04:55 collazoandy4 File Added: 1. added validation.patch
2021-04-28 04:55 collazoandy4 File Added: 2. improve message.patch
2021-04-28 20:57 rqueralta Assigned To Retail => rqueralta
2021-04-28 20:58 rqueralta Status new => scheduled
2021-05-12 16:01 hgbot Note Added: 0128044
2021-05-14 08:06 hgbot Resolution open => fixed
2021-05-14 08:06 hgbot Status scheduled => resolved
2021-05-14 08:06 hgbot Note Added: 0128087
2021-05-14 08:06 hgbot Note Added: 0128088
2021-05-14 08:07 marvintm Review Assigned To => marvintm
2021-05-14 08:07 marvintm Status resolved => closed
2021-05-14 08:07 marvintm Fixed in Version => RR21Q3
2021-05-14 21:31 hgbot Note Added: 0128133
2021-05-14 21:31 hgbot Note Added: 0128135
2021-05-17 08:21 marvintm Note Added: 0128185
2021-06-17 16:50 collazoandy4 Relationship added related to 0047175
2021-07-08 17:12 collazoandy4 Relationship added related to 0047367
2021-07-27 04:17 collazoandy4 Relationship added related to 0047459


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker