Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046378Retail ModulesWeb POSpublic2021-04-28 04:512021-05-17 08:21
Reportercollazoandy4 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046378: Check barcode duplicity in Digital Coupons
DescriptionTwo digital coupons can have the same barcode and a wrong accounting information can be defined
Steps To Reproduce- Log-in in the POS (YS-11 livebuilds with modules)
- Add a product
- Go to the payment tab
- Add a "Digital Coupon" as payment
- Fill the coupon data with an amount less than the pending amount and a barcode of 50
- Add another coupon with the same barcode value (50) with an amount equal to the pending amount
- Check the second coupon can be created without any issue
Proposed SolutionAdd a new preference to check the barcode duplicity and a new hook in org.openbravo.retail.chequecadeau module to check if the same barcode exists in a coupon
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047175 closed rqueralta Take into account draft tickets when barcode is checked for duplicity in Digital Coupons 
related to defect 0047367 closed rqueralta Do not check barcode duplicity in digital coupons if barcode is empty 
related to defect 0047459 closed rqueralta Check issuing company in Digital Coupons 
Attached Filespatch 1. added validation.patch (11,043) 2021-04-28 04:55
https://issues.openbravo.com/file_download.php?file_id=15584&type=bug
patch 2. improve message.patch (2,061) 2021-04-28 04:55
https://issues.openbravo.com/file_download.php?file_id=15585&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-04-28 04:51collazoandy4New Issue
2021-04-28 04:51collazoandy4Assigned To => Retail
2021-04-28 04:51collazoandy4OBNetwork customer => Gold
2021-04-28 04:51collazoandy4Resolution time => 1620684000
2021-04-28 04:51collazoandy4Triggers an Emergency Pack => No
2021-04-28 04:55collazoandy4File Added: 1. added validation.patch
2021-04-28 04:55collazoandy4File Added: 2. improve message.patch
2021-04-28 20:57rqueraltaAssigned ToRetail => rqueralta
2021-04-28 20:58rqueraltaStatusnew => scheduled
2021-05-12 16:01hgbotMerge Request Status => open
2021-05-12 16:01hgbotNote Added: 0128044
2021-05-14 08:06hgbotResolutionopen => fixed
2021-05-14 08:06hgbotStatusscheduled => resolved
2021-05-14 08:06hgbotNote Added: 0128087
2021-05-14 08:06hgbotMerge Request Statusopen => merged
2021-05-14 08:06hgbotNote Added: 0128088
2021-05-14 08:06hgbotMerge Request Statusmerged => approved
2021-05-14 08:07marvintmReview Assigned To => marvintm
2021-05-14 08:07marvintmStatusresolved => closed
2021-05-14 08:07marvintmFixed in Version => RR21Q3
2021-05-14 21:31hgbotNote Added: 0128133
2021-05-14 21:31hgbotNote Added: 0128135
2021-05-17 08:21marvintmNote Added: 0128185
2021-06-17 16:50collazoandy4Relationship addedrelated to 0047175
2021-07-08 17:12collazoandy4Relationship addedrelated to 0047367
2021-07-27 04:17collazoandy4Relationship addedrelated to 0047459

Notes
(0128044)
hgbot   
2021-05-12 16:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/5 [^]
(0128087)
hgbot   
2021-05-14 08:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau [^]
Changeset: 546d16a80854b2b9007b169d4903a9da0cb812bf
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-05-11T17:41:59-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/commit/546d16a80854b2b9007b169d4903a9da0cb812bf [^]

Fixed BUG-46378: Added a new preference to check the barcode duplicity and a new hook in org.openbravo.retail.chequecadeau module to check if the same barcode exists in a coupon

---
A src-db/database/sourcedata/AD_REF_LIST.xml
A src/org/openbravo/retail/chequecadeau/hooks/ValidateChequeCadeauBarcode.java
A web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/chequecadeau/ChequeCadeauComponentProvider.java
---
(0128088)
hgbot   
2021-05-14 08:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/5 [^]
(0128133)
hgbot   
2021-05-14 21:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/6 [^]
(0128135)
hgbot   
2021-05-14 21:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/merge_requests/6 [^]
(0128185)
marvintm   
2021-05-17 08:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau [^] [^]
Changeset: dd9f40b16d5822791de18d91ee5095d54464ce67
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-05-14T15:29:23-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.chequecadeau/-/commit/dd9f40b16d5822791de18d91ee5095d54464ce67 [^] [^]

Fixed BUG-46637: Removed OB definition

---
M web/org.openbravo.retail.chequecadeau/js/hooks/hookObidcoPreAddCouponHook.js
---