Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046325
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2021-04-22 14:102021-05-11 16:28
ReporterjmelinView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046325: JIRA 1738 - Missing columns compare to mockup

DescriptionIn the mockup, you have 3 columns (code, name, amount)
Currently, you have 1 column (name) for "order discounts" and 2 for “lines discount” (name, amount)



Steps To Reproduce1. Connect to POS VBS-2
2. Create an order and open "Order Discounts" window (order discounts or line discount)
=> The list of column available are different from mockups
3. Select a product and then select "Discount" from popup menu
=> list of column are different
TagsTakeaway
Attached Filespng file icon mock-up_0efeeb00-218e-4141-be44-d36f0139f2d2.png [^] (61,275 bytes) 2021-04-22 14:12


png file icon orderdiscount-window_bbfef99e-75b2-410d-9ea1-a8aad735a49a.png [^] (33,848 bytes) 2021-04-22 14:12


png file icon linediscount-window_b27f9e17-1c79-462b-807e-1265cc8717d5.png [^] (46,280 bytes) 2021-04-22 14:12

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046412TAP closedjavierRodriguez JIRA 1738 - Missing columns compare to mockup 

-  Notes
(0127498)
marvintm (viewer)
2021-04-23 13:46

 The mockup contained a "Code" column, but there is no "Code" concept in Openbravo currently, so the only columns that we show are the discount name and amount.
(0127499)
marvintm (viewer)
2021-04-23 13:54

 We don't have "Code" property, so line level discounts are ok. However, in order discounts ,we need to add the "amount" apart from the name
(0127909)
hgbot (developer)
2021-05-08 17:56

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/443 [^]
(0127992)
hgbot (developer)
2021-05-11 14:33

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/497 [^]
(0127995)
hgbot (developer)
2021-05-11 16:26

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 577daa929f55f86b90093b18ed5c6ce1a91fa53d
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T16:24:14+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/577daa929f55f86b90093b18ed5c6ce1a91fa53d [^]

Fixed ISSUE-46325: Include missing elements in order discount panel

---
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.scss
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/__test__/OrderDiscountAmountCell.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/index.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/OrderDiscountList.config.json
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0127996)
hgbot (developer)
2021-05-11 16:26

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7f3d624653929688620171a0849525edd5f2ad75
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T16:24:14+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7f3d624653929688620171a0849525edd5f2ad75 [^]

Related to ISSUE-46325: Fix DiscountAmountCell style

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountAmountCell/DiscountAmountCell.scss
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.scss
---
(0127997)
hgbot (developer)
2021-05-11 16:26

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4c71669932e0ab2a6c82a48a5fcaf644b8d07bf4
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T16:24:14+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4c71669932e0ab2a6c82a48a5fcaf644b8d07bf4 [^]

Related to ISSUE-46325: Remove useless registry

---
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0127998)
hgbot (developer)
2021-05-11 16:26

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/443 [^]
(0127999)
hgbot (developer)
2021-05-11 16:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: fde084f7a187ad0aa4ab5ded87a7d5a4a8685fec
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T14:28:29+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/fde084f7a187ad0aa4ab5ded87a7d5a4a8685fec [^]

Related to ISSUE-46325: Fix colum header style in grid component

---
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseHeaderRender.scss
---
(0128000)
hgbot (developer)
2021-05-11 16:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/497 [^]

- Issue History
Date Modified Username Field Change
2021-04-22 14:10 jmelin New Issue
2021-04-22 14:10 jmelin Assigned To => Retail
2021-04-22 14:10 jmelin OBNetwork customer => Gold
2021-04-22 14:10 jmelin Triggers an Emergency Pack => No
2021-04-22 14:11 jmelin Tag Attached: Takeaway
2021-04-22 14:12 jmelin File Added: mock-up_0efeeb00-218e-4141-be44-d36f0139f2d2.png
2021-04-22 14:12 jmelin File Added: orderdiscount-window_bbfef99e-75b2-410d-9ea1-a8aad735a49a.png
2021-04-22 14:12 jmelin File Added: linediscount-window_b27f9e17-1c79-462b-807e-1265cc8717d5.png
2021-04-22 17:34 guilleaer Resolution time => 1620079200
2021-04-23 13:46 marvintm Review Assigned To => marvintm
2021-04-23 13:46 marvintm Note Added: 0127498
2021-04-23 13:46 marvintm Status new => closed
2021-04-23 13:46 marvintm Resolution open => no change required
2021-04-23 13:54 marvintm Note Added: 0127499
2021-04-23 13:54 marvintm Status closed => new
2021-04-23 13:54 marvintm Resolution no change required => open
2021-04-24 16:38 guilleaer Assigned To Retail => javierRodriguez
2021-04-29 10:30 guilleaer Status new => scheduled
2021-05-08 17:56 hgbot Merge Request Status => open
2021-05-08 17:56 hgbot Note Added: 0127909
2021-05-11 14:33 hgbot Note Added: 0127992
2021-05-11 16:08 hgbot Merge Request Status open => approved
2021-05-11 16:26 hgbot Resolution open => fixed
2021-05-11 16:26 hgbot Status scheduled => closed
2021-05-11 16:26 hgbot Note Added: 0127995
2021-05-11 16:26 hgbot Note Added: 0127996
2021-05-11 16:26 hgbot Note Added: 0127997
2021-05-11 16:26 hgbot Note Added: 0127998
2021-05-11 16:28 hgbot Note Added: 0127999
2021-05-11 16:28 hgbot Note Added: 0128000

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker