Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046325POS2POSpublic2021-04-22 14:102021-05-11 16:28
Reporterjmelin 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046325: JIRA 1738 - Missing columns compare to mockup
DescriptionIn the mockup, you have 3 columns (code, name, amount)
Currently, you have 1 column (name) for "order discounts" and 2 for “lines discount” (name, amount)



Steps To Reproduce1. Connect to POS VBS-2
2. Create an order and open "Order Discounts" window (order discounts or line discount)
=> The list of column available are different from mockups
3. Select a product and then select "Discount" from popup menu
=> list of column are different
Proposed Solution
Additional Information
TagsTakeaway
Relationships
depends on backport 0046412TAP closed javierRodriguez JIRA 1738 - Missing columns compare to mockup 
Attached Filespng mock-up_0efeeb00-218e-4141-be44-d36f0139f2d2.png (61,275) 2021-04-22 14:12
https://issues.openbravo.com/file_download.php?file_id=15560&type=bug
png

png orderdiscount-window_bbfef99e-75b2-410d-9ea1-a8aad735a49a.png (33,848) 2021-04-22 14:12
https://issues.openbravo.com/file_download.php?file_id=15561&type=bug
png

png linediscount-window_b27f9e17-1c79-462b-807e-1265cc8717d5.png (46,280) 2021-04-22 14:12
https://issues.openbravo.com/file_download.php?file_id=15562&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-04-22 14:10jmelinNew Issue
2021-04-22 14:10jmelinAssigned To => Retail
2021-04-22 14:10jmelinOBNetwork customer => Gold
2021-04-22 14:10jmelinTriggers an Emergency Pack => No
2021-04-22 14:11jmelinTag Attached: Takeaway
2021-04-22 14:12jmelinFile Added: mock-up_0efeeb00-218e-4141-be44-d36f0139f2d2.png
2021-04-22 14:12jmelinFile Added: orderdiscount-window_bbfef99e-75b2-410d-9ea1-a8aad735a49a.png
2021-04-22 14:12jmelinFile Added: linediscount-window_b27f9e17-1c79-462b-807e-1265cc8717d5.png
2021-04-22 17:34guilleaerResolution time => 1620079200
2021-04-23 13:46marvintmReview Assigned To => marvintm
2021-04-23 13:46marvintmNote Added: 0127498
2021-04-23 13:46marvintmStatusnew => closed
2021-04-23 13:46marvintmResolutionopen => no change required
2021-04-23 13:54marvintmNote Added: 0127499
2021-04-23 13:54marvintmStatusclosed => new
2021-04-23 13:54marvintmResolutionno change required => open
2021-04-24 16:38guilleaerAssigned ToRetail => javierRodriguez
2021-04-29 10:30guilleaerStatusnew => scheduled
2021-05-08 17:56hgbotMerge Request Status => open
2021-05-08 17:56hgbotNote Added: 0127909
2021-05-11 14:33hgbotNote Added: 0127992
2021-05-11 16:08hgbotMerge Request Statusopen => approved
2021-05-11 16:26hgbotResolutionopen => fixed
2021-05-11 16:26hgbotStatusscheduled => closed
2021-05-11 16:26hgbotNote Added: 0127995
2021-05-11 16:26hgbotNote Added: 0127996
2021-05-11 16:26hgbotNote Added: 0127997
2021-05-11 16:26hgbotNote Added: 0127998
2021-05-11 16:28hgbotNote Added: 0127999
2021-05-11 16:28hgbotNote Added: 0128000

Notes
(0127498)
marvintm   
2021-04-23 13:46   
The mockup contained a "Code" column, but there is no "Code" concept in Openbravo currently, so the only columns that we show are the discount name and amount.
(0127499)
marvintm   
2021-04-23 13:54   
We don't have "Code" property, so line level discounts are ok. However, in order discounts ,we need to add the "amount" apart from the name
(0127909)
hgbot   
2021-05-08 17:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/443 [^]
(0127992)
hgbot   
2021-05-11 14:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/497 [^]
(0127996)
hgbot   
2021-05-11 16:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7f3d624653929688620171a0849525edd5f2ad75
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T16:24:14+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7f3d624653929688620171a0849525edd5f2ad75 [^]

Related to ISSUE-46325: Fix DiscountAmountCell style

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountAmountCell/DiscountAmountCell.scss
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.scss
---
(0127995)
hgbot   
2021-05-11 16:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 577daa929f55f86b90093b18ed5c6ce1a91fa53d
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T16:24:14+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/577daa929f55f86b90093b18ed5c6ce1a91fa53d [^]

Fixed ISSUE-46325: Include missing elements in order discount panel

---
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.scss
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/__test__/OrderDiscountAmountCell.test.jsx
A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/index.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/OrderDiscountList.config.json
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0127997)
hgbot   
2021-05-11 16:26   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4c71669932e0ab2a6c82a48a5fcaf644b8d07bf4
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T16:24:14+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4c71669932e0ab2a6c82a48a5fcaf644b8d07bf4 [^]

Related to ISSUE-46325: Remove useless registry

---
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0127998)
hgbot   
2021-05-11 16:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/443 [^]
(0127999)
hgbot   
2021-05-11 16:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: fde084f7a187ad0aa4ab5ded87a7d5a4a8685fec
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-11T14:28:29+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/fde084f7a187ad0aa4ab5ded87a7d5a4a8685fec [^]

Related to ISSUE-46325: Fix colum header style in grid component

---
M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseHeaderRender.scss
---
(0128000)
hgbot   
2021-05-11 16:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/497 [^]