Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0046281 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [POS2] Core | minor | have not tried | 2021-04-16 10:00 | 2021-04-16 14:04 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | Pre packaging ( pi ) | |||||||
Regression date | 2021-04-15 | |||||||
Regression introduced in release | ||||||||
Regression introduced by commit | https://gitlab.com/openbravo/product/openbravo/-/commit/1254c2bec0d1621912813df5887e0b06e2958d36 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0046281: storyshots test includes stories within node_modules | |||||||
Description | When executing storyshot test, stories that are defined within node_modules are executed. Note that those stories are not appearing in storybook although they should (might they silently fail not generating any story?). | |||||||
Steps To Reproduce | Execute: npm test modules/org.openbravo.core2/web-jspack/org.openbravo.core2/src/storybook/Storyshots.test.js -> Check execution log: * Many occurrences of console.warn Story with id basics-form-field--field already exists in the store! * Finally Tests: 705 passed, 705 total -> Currently there should be ~ 400 Snapshots: 401 written, 401 total | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||
|
Notes | |
(0127306) hgbot (developer) 2021-04-16 10:20 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/462 [^] |
(0127325) hgbot (developer) 2021-04-16 14:04 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/462 [^] |
(0127326) hgbot (developer) 2021-04-16 14:04 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 06705744e25d64bfe1025e1270f4a39f3f2111a6 Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 2021-04-16T10:17:21+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/06705744e25d64bfe1025e1270f4a39f3f2111a6 [^] fixes BUG-46281: storyshots test includes stories within node_modules We are now looking for stories one level deeper (starting at src directory) which is correct as all stories should be placed there anyway. --- M web-jspack/org.openbravo.core2/.storybook/main.js M web-jspack/org.openbravo.core2/src/storybook/OBStories2SnapsConverter.js --- |
Issue History | |||
Date Modified | Username | Field | Change |
2021-04-16 10:00 | alostale | New Issue | |
2021-04-16 10:00 | alostale | Assigned To | => alostale |
2021-04-16 10:00 | alostale | Triggers an Emergency Pack | => No |
2021-04-16 10:00 | alostale | Steps to Reproduce Updated | View Revisions |
2021-04-16 10:01 | alostale | Relationship added | caused by 0045971 |
2021-04-16 10:02 | alostale | Regression level | => Pre packaging ( pi ) |
2021-04-16 10:02 | alostale | Regression date | => 2021-04-15 |
2021-04-16 10:02 | alostale | Regression introduced by commit | => https://gitlab.com/openbravo/product/openbravo/-/commit/1254c2bec0d1621912813df5887e0b06e2958d36 [^] |
2021-04-16 10:20 | hgbot | Note Added: 0127306 | |
2021-04-16 14:04 | hgbot | Note Added: 0127325 | |
2021-04-16 14:04 | hgbot | Resolution | open => fixed |
2021-04-16 14:04 | hgbot | Status | new => closed |
2021-04-16 14:04 | hgbot | Note Added: 0127326 |
Copyright © 2000 - 2009 MantisBT Group |