Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046281POS2Corepublic2021-04-16 10:002021-04-16 14:04
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelPre packaging ( pi )
Regression date2021-04-15
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/1254c2bec0d1621912813df5887e0b06e2958d36 [^]
Triggers an Emergency PackNo
Summary0046281: storyshots test includes stories within node_modules
DescriptionWhen executing storyshot test, stories that are defined within node_modules are executed.

Note that those stories are not appearing in storybook although they should (might they silently fail not generating any story?).
Steps To ReproduceExecute: npm test modules/org.openbravo.core2/web-jspack/org.openbravo.core2/src/storybook/Storyshots.test.js

 -> Check execution log:
  * Many occurrences of
       console.warn
         Story with id basics-form-field--field already exists in the store!
  * Finally
     Tests: 705 passed, 705 total -> Currently there should be ~ 400
     Snapshots: 401 written, 401 total
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0045971 closed AugustoMauch Openbravo ERP New UI - infrastructure improvements 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-04-16 10:00alostaleNew Issue
2021-04-16 10:00alostaleAssigned To => alostale
2021-04-16 10:00alostaleOBNetwork customer => No
2021-04-16 10:00alostaleTriggers an Emergency Pack => No
2021-04-16 10:00alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22321#r22321
2021-04-16 10:01alostaleRelationship addedcaused by 0045971
2021-04-16 10:02alostaleRegression level => Pre packaging ( pi )
2021-04-16 10:02alostaleRegression date => 2021-04-15
2021-04-16 10:02alostaleRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/1254c2bec0d1621912813df5887e0b06e2958d36 [^]
2021-04-16 10:20hgbotMerge Request Status => open
2021-04-16 10:20hgbotNote Added: 0127306
2021-04-16 13:11hgbotMerge Request Statusopen => approved
2021-04-16 14:04hgbotNote Added: 0127325
2021-04-16 14:04hgbotResolutionopen => fixed
2021-04-16 14:04hgbotStatusnew => closed
2021-04-16 14:04hgbotNote Added: 0127326

Notes
(0127306)
hgbot   
2021-04-16 10:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/462 [^]
(0127325)
hgbot   
2021-04-16 14:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/462 [^]
(0127326)
hgbot   
2021-04-16 14:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 06705744e25d64bfe1025e1270f4a39f3f2111a6
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-04-16T10:17:21+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/06705744e25d64bfe1025e1270f4a39f3f2111a6 [^]

fixes BUG-46281: storyshots test includes stories within node_modules

We are now looking for stories one level deeper (starting at src
directory) which is correct as all stories should be placed there
anyway.

---
M web-jspack/org.openbravo.core2/.storybook/main.js
M web-jspack/org.openbravo.core2/src/storybook/OBStories2SnapsConverter.js
---