0046257: Error While Importing: while a ticket is being deleted is possible to add an item using RFID (in 19q3 version)

Description

This is a problem happening under following circumstances:
- 19Q3 version
- "Save removed ticket" functionality enabled
- RFID functionality enabled

Steps To Reproduce

According to the terminal log (attached), the "addProduct" process is executed while the "deleteCurrentOrder" process is being executed

This is causing that a corrupted line is added to the deleted ticket. This corrupted line is as follows:
qty=1
lineGrossAmount=0
obposIsDeleted=true
taxlines array missed
tax property missed

So the ticket is stuck in Errors While Importing window

Proposed Solution

The RFID should be disabled while the deleteCurrentOrder process is executed

Tags

No tags attached.

Attached Files

issue.png [^] (334,779 bytes) 2021-04-13 13:10

46257_19Q3.diff [^] (888 bytes) 2021-04-14 15:58 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
index d02e02b37..e3b474628 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
@@ -743,9 +743,11 @@ enyo.kind({
       execution = OB.UTIL.ProcessController.start('deleteCurrentOrder');
 
     inEvent.status = true;
+    OB.UTIL.setScanningFocus(false);
     this.leftToolbarDisabled(inSender, inEvent);
     receipt.deleteOrder(this, function() {
       inEvent.status = false;
+      OB.UTIL.setScanningFocus(true);
       me.leftToolbarDisabled(inSender, inEvent);
       OB.UTIL.ProcessController.finish('deleteCurrentOrder', execution);
       if (OB.MobileApp.model.hasPermission('OBPOS_remove_ticket', true)) {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0046421	closed	ranjith_qualiantech_com	Error While Importing: while a ticket is being deleted is possible to add an item (addProduct) using RFID (in 19q3 version)
related to	defect	0047499	closed	ranjith_qualiantech_com	The "addProduct" function is executd while a ticket is being deleted in SCO mode, generating an inconsistent order
causes	defect	0049654	closed	ranjith_qualiantech_com	Unable to add products via RFID, keyboard cannot be entered After deleting the receipt, RFID was disabled/disconnected

Notes
(0127383) hgbot (developer) 2021-04-20 12:46	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/384 [^]

(0127409) hgbot (developer) 2021-04-21 10:43	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: c3ec05eaf219e9f5c782e0c6dfe5cd9798528686 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-04-21T08:43:14+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c3ec05eaf219e9f5c782e0c6dfe5cd9798528686 [^] Fixed ISSUE-46257: ScanningFocus should be disabled when deleting the receipt --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js ---

(0127410) hgbot (developer) 2021-04-21 10:43	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/384 [^]

Issue History
Date Modified	Username	Field	Change
2021-04-13 13:03	maite	New Issue
2021-04-13 13:03	maite	Assigned To	=> Retail
2021-04-13 13:03	maite	Resolution time	=> 1620079200
2021-04-13 13:03	maite	Triggers an Emergency Pack	=> No
2021-04-13 13:10	maite	File Added: issue.png
2021-04-14 08:57	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2021-04-14 15:58	ranjith_qualiantech_com	File Added: 46257_19Q3.diff
2021-04-20 12:46	hgbot	Note Added: 0127383
2021-04-21 10:43	hgbot	Resolution	open => fixed
2021-04-21 10:43	hgbot	Status	new => closed
2021-04-21 10:43	hgbot	Fixed in Version	=> RR21Q3
2021-04-21 10:43	hgbot	Note Added: 0127409
2021-04-21 10:43	hgbot	Note Added: 0127410
2021-04-29 13:56	maite	Relationship added	related to 0046421
2021-08-04 09:52	maite	Relationship added	related to 0047499
2022-06-27 10:00	swathi_kamal	Relationship added	causes 0049654