Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0046233 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | minor | have not tried | 2021-04-09 09:51 | 2021-04-09 10:06 | |||
Reporter | cberner | View Status | public | |||||
Assigned To | cberner | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR21Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0046233: In PrintTemplate generator getOrgVariable method doesn't use Language Code where necessary | |||||||
Description | Language code is missing and language id is being used instead, in PrintTemplate getOrgVariable method, this compares the language of a translatable element with the provided code/default one, which will always be false because language is the language id not the language code. Problematic code: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/external-device/printing/PrintTemplate.js#L141 [^] | |||||||
Steps To Reproduce | 1. Create a translatable OrgVariable 2. Use the variable in a printing template 3. Print it Check that nothing is printed, and this is due to the previous check mentioned. | |||||||
Proposed Solution | Use language code instead of id for comparison. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0127189) hgbot (developer) 2021-04-09 10:03 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/371 [^] |
(0127190) hgbot (developer) 2021-04-09 10:03 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/205 [^] |
(0127191) hgbot (developer) 2021-04-09 10:06 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: c32842b9bc67e04c0ef30e2f9ca2cc45705f61b1 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2021-04-09T10:01:05+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c32842b9bc67e04c0ef30e2f9ca2cc45705f61b1 [^] Fixes ISSUE-46233: In PrintTemplate generator getOrgVariable method doesn't use Language Code Language code is now being used instead of language id(which was incorrect) for selecting the correct OrgVariable in a template. Tests have been updated with a new case so it detects this particular case. --- M web-test/external-device/printing/PrintTemplate.test.js M web-test/external-device/printing/printResult.txt M web-test/external-device/printing/template.xml M web/org.openbravo.retail.posterminal/app/external-device/printing/PrintTemplate.js --- |
(0127192) hgbot (developer) 2021-04-09 10:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/371 [^] |
(0127193) hgbot (developer) 2021-04-09 10:06 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 9e0a5f3f32987c31a8046df894d4aee8cc99c829 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2021-04-09T09:59:05+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9e0a5f3f32987c31a8046df894d4aee8cc99c829 [^] Related to ISSUE-46233: In PrintTemplate generator getOrgVariable method doesn't use Language Code Comparison is wrong in printtemplate because of missing language code. This commits adds language code to the organization masterdata model as langCode. --- M src/org/openbravo/mobile/core/master/OrgVariableProperties.java --- |
(0127194) hgbot (developer) 2021-04-09 10:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/205 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-04-09 09:51 | cberner | New Issue | |
2021-04-09 09:51 | cberner | Assigned To | => cberner |
2021-04-09 09:51 | cberner | Triggers an Emergency Pack | => No |
2021-04-09 10:03 | hgbot | Note Added: 0127189 | |
2021-04-09 10:03 | hgbot | Note Added: 0127190 | |
2021-04-09 10:06 | hgbot | Resolution | open => fixed |
2021-04-09 10:06 | hgbot | Status | new => closed |
2021-04-09 10:06 | hgbot | Fixed in Version | => RR21Q3 |
2021-04-09 10:06 | hgbot | Note Added: 0127191 | |
2021-04-09 10:06 | hgbot | Note Added: 0127192 | |
2021-04-09 10:06 | hgbot | Note Added: 0127193 | |
2021-04-09 10:06 | hgbot | Note Added: 0127194 |
Copyright © 2000 - 2009 MantisBT Group |