Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0046233 | Retail Modules | Web POS | public | 2021-04-09 09:51 | 2021-04-09 10:06 |
|
| Reporter | cberner | |
| Assigned To | cberner | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR21Q3 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0046233: In PrintTemplate generator getOrgVariable method doesn't use Language Code where necessary |
| Description | Language code is missing and language id is being used instead, in PrintTemplate getOrgVariable method, this compares the language of a translatable element with the provided code/default one, which will always be false because language is the language id not the language code.
Problematic code: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/external-device/printing/PrintTemplate.js#L141 [^] |
| Steps To Reproduce | 1. Create a translatable OrgVariable
2. Use the variable in a printing template
3. Print it
Check that nothing is printed, and this is due to the previous check mentioned. |
| Proposed Solution | Use language code instead of id for comparison. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-04-09 09:51 | cberner | New Issue | |
| 2021-04-09 09:51 | cberner | Assigned To | => cberner |
| 2021-04-09 09:51 | cberner | Triggers an Emergency Pack | => No |
| 2021-04-09 10:03 | hgbot | Note Added: 0127189 | |
| 2021-04-09 10:03 | hgbot | Note Added: 0127190 | |
| 2021-04-09 10:06 | hgbot | Resolution | open => fixed |
| 2021-04-09 10:06 | hgbot | Status | new => closed |
| 2021-04-09 10:06 | hgbot | Fixed in Version | => RR21Q3 |
| 2021-04-09 10:06 | hgbot | Note Added: 0127191 | |
| 2021-04-09 10:06 | hgbot | Note Added: 0127192 | |
| 2021-04-09 10:06 | hgbot | Note Added: 0127193 | |
| 2021-04-09 10:06 | hgbot | Note Added: 0127194 | |
|
Notes |
|
|
(0127189)
|
|
hgbot
|
|
2021-04-09 10:03
|
|
|
|
|
(0127190)
|
|
hgbot
|
|
2021-04-09 10:03
|
|
|
|
|
(0127191)
|
|
hgbot
|
|
2021-04-09 10:06
|
|
|
|
|
(0127192)
|
|
hgbot
|
|
2021-04-09 10:06
|
|
|
|
|
(0127193)
|
|
hgbot
|
|
2021-04-09 10:06
|
|
|
|
|
(0127194)
|
|
hgbot
|
|
2021-04-09 10:06
|
|
|