Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046123
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2021-03-23 14:302021-03-29 07:47
ReporterjetxarriView Statuspublic 
Assigned Torqueralta 
PriorityhighResolutionfixedFixed in VersionRR21Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046123: Incompatibility fix for issue 45905 module org.openbravo.retail.maxlevelofcash is broken

DescriptionIn the fix for issue 45905 the decision was to hide all the information and also avoid the initialization of some properties like "total" by payment.

Due to that module "org.openbravo.retail.maxlevelofcash" is trying to get
var currentCash = match.get('total');

And total is not set. As a consequence, the user can not execute the cashup.
Steps To Reproduce-Install module org.openbravo.retail.maxlevelofcash
-Configure a terminal to work with safe box
-Go to the terminal
-Try to do a cash management

As some attributes were not initialized the js code fails
Proposed SolutionInitialize all the properties but at the end put the following code


if (this.model.attributes.issafebox) {
      this.$.startingCashPayName.parent.setStyle('display:none');
      this.$.availableLbl.parent.setStyle('display:none');
      this.$.tenderedLbl.parent.setStyle('display:none');
      this.$.tenderedForeignAmnt.parent.setStyle('display:none');
      this.$.separator.setStyle('display:none');
    }

In that way the rest of the code will not fail but the information will be hidden as it was in the original fix.
TagsNOR
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0045908 closedrqueralta js error when 'Count Safe Box' 
related to defect 0046122 closedrqueralta Javascript error when executing Count Safe Box process 
related to defect 0046121 closedrqueralta Next button enabled in Count Safe Box 

-  Notes
(0126936)
hgbot (developer)
2021-03-26 04:12

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/353 [^]
(0126946)
hgbot (developer)
2021-03-26 11:44

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/353 [^]
(0126954)
hgbot (developer)
2021-03-26 16:37

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/355 [^]
(0126970)
hgbot (developer)
2021-03-29 07:47

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 007a3a66919232039622a908427208daeaa1bb3f
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-03-29T05:47:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/007a3a66919232039622a908427208daeaa1bb3f [^]

Fix BUG-46123: Moved the if condition to the end to allow initialize all the properties before hide the information for safebox payment methods

---
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/listdepositsdrops.js
---
(0126971)
hgbot (developer)
2021-03-29 07:47

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/355 [^]

- Issue History
Date Modified Username Field Change
2021-03-23 14:30 jetxarri New Issue
2021-03-23 14:30 jetxarri Assigned To => Retail
2021-03-23 14:30 jetxarri Triggers an Emergency Pack => No
2021-03-23 14:34 rafaroda Tag Attached: NOR
2021-03-23 14:34 rafaroda Relationship added related to 0046122
2021-03-23 14:36 rafaroda Relationship added related to 0046121
2021-03-23 14:37 rafaroda Relationship added related to 0045908
2021-03-23 14:39 rafaroda OBNetwork customer => Gold
2021-03-23 14:39 rafaroda Resolution time => 1617919200
2021-03-23 21:07 rqueralta Assigned To Retail => rqueralta
2021-03-23 21:07 rqueralta Status new => scheduled
2021-03-26 04:12 hgbot Merge Request Status => open
2021-03-26 04:12 hgbot Note Added: 0126936
2021-03-26 11:44 hgbot Note Added: 0126946
2021-03-26 16:37 hgbot Note Added: 0126954
2021-03-29 07:47 hgbot Merge Request Status open => approved
2021-03-29 07:47 hgbot Note Added: 0126970
2021-03-29 07:47 hgbot Note Added: 0126971
2021-03-29 07:47 marvintm Status scheduled => resolved
2021-03-29 07:47 marvintm Fixed in Version => RR21Q2
2021-03-29 07:47 marvintm Resolution open => fixed
2021-03-29 07:47 marvintm Review Assigned To => marvintm
2021-03-29 07:47 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker