Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046123Retail ModulesWeb POSpublic2021-03-23 14:302021-03-29 07:47
Reporterjetxarri 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR21Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046123: Incompatibility fix for issue 45905 module org.openbravo.retail.maxlevelofcash is broken
DescriptionIn the fix for issue 45905 the decision was to hide all the information and also avoid the initialization of some properties like "total" by payment.

Due to that module "org.openbravo.retail.maxlevelofcash" is trying to get
var currentCash = match.get('total');

And total is not set. As a consequence, the user can not execute the cashup.
Steps To Reproduce-Install module org.openbravo.retail.maxlevelofcash
-Configure a terminal to work with safe box
-Go to the terminal
-Try to do a cash management

As some attributes were not initialized the js code fails
Proposed SolutionInitialize all the properties but at the end put the following code


if (this.model.attributes.issafebox) {
      this.$.startingCashPayName.parent.setStyle('display:none');
      this.$.availableLbl.parent.setStyle('display:none');
      this.$.tenderedLbl.parent.setStyle('display:none');
      this.$.tenderedForeignAmnt.parent.setStyle('display:none');
      this.$.separator.setStyle('display:none');
    }

In that way the rest of the code will not fail but the information will be hidden as it was in the original fix.
Additional Information
TagsNOR
Relationships
related to defect 0045908 closed rqueralta js error when 'Count Safe Box' 
related to defect 0046122 closed rqueralta Javascript error when executing Count Safe Box process 
related to defect 0046121 closed rqueralta Next button enabled in Count Safe Box 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-03-23 14:30jetxarriNew Issue
2021-03-23 14:30jetxarriAssigned To => Retail
2021-03-23 14:30jetxarriTriggers an Emergency Pack => No
2021-03-23 14:34rafarodaTag Attached: NOR
2021-03-23 14:34rafarodaRelationship addedrelated to 0046122
2021-03-23 14:36rafarodaRelationship addedrelated to 0046121
2021-03-23 14:37rafarodaRelationship addedrelated to 0045908
2021-03-23 14:39rafarodaResolution time => 1617919200
2021-03-23 21:07rqueraltaAssigned ToRetail => rqueralta
2021-03-23 21:07rqueraltaStatusnew => scheduled
2021-03-26 04:12hgbotNote Added: 0126936
2021-03-26 11:44hgbotNote Added: 0126946
2021-03-26 16:37hgbotNote Added: 0126954
2021-03-29 07:47hgbotNote Added: 0126970
2021-03-29 07:47hgbotNote Added: 0126971
2021-03-29 07:47marvintmStatusscheduled => resolved
2021-03-29 07:47marvintmFixed in Version => RR21Q2
2021-03-29 07:47marvintmResolutionopen => fixed
2021-03-29 07:47marvintmReview Assigned To => marvintm
2021-03-29 07:47marvintmStatusresolved => closed

Notes
(0126936)
hgbot   
2021-03-26 04:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/353 [^]
(0126946)
hgbot   
2021-03-26 11:44   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/353 [^]
(0126954)
hgbot   
2021-03-26 16:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/355 [^]
(0126970)
hgbot   
2021-03-29 07:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 007a3a66919232039622a908427208daeaa1bb3f
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-03-29T05:47:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/007a3a66919232039622a908427208daeaa1bb3f [^]

Fix BUG-46123: Moved the if condition to the end to allow initialize all the properties before hide the information for safebox payment methods

---
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/listdepositsdrops.js
---
(0126971)
hgbot   
2021-03-29 07:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/355 [^]