Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045936 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | always | 2021-02-22 21:44 | 2021-02-24 10:44 | |||
| Reporter | gorka_gil | View Status | public | |||||
| Assigned To | gorka_gil | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045936: eslint git hook fails to execute in systems without realpath | |||||||
| Description | In operating systems like macOS that don't have realpath, the git hook of eslint fails to execute. Error message: pre-commit: Performing lint check on modified js resources Checking npm and required packages are installed... Npm and all required tools are installed. Done! Oops! Something went wrong! :( ESLint: 7.17.0 No files matching the pattern "GIT" were found. Please check for typing mistakes in the pattern. | |||||||
| Steps To Reproduce | In macOS, add the git hook of eslint (http://wiki.openbravo.com/wiki/JavaScript_Coding_Conventions#Git_hooks [^]) modify a js file that has the new formatting, for example: in mobile.core: web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js and try to do a commit | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0126281) hgbot (developer) 2021-02-22 21:53 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/319 [^] |
|
(0126316) hgbot (developer) 2021-02-24 10:44 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/319 [^] |
|
(0126317) hgbot (developer) 2021-02-24 10:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 217fa1e2107666bb045033dfb44933d929e5069a Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-24T09:44:11+00:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/217fa1e2107666bb045033dfb44933d929e5069a [^] Fixes ISSUE-45936: Fix jslint for operating systems that don't have realpath This apply for example to macOS --- M modules/org.openbravo.client.kernel/jslint/jslint --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-02-22 21:44 | gorka_gil | New Issue | |
| 2021-02-22 21:44 | gorka_gil | Assigned To | => gorka_gil |
| 2021-02-22 21:44 | gorka_gil | OBNetwork customer | => No |
| 2021-02-22 21:44 | gorka_gil | Modules | => Core |
| 2021-02-22 21:44 | gorka_gil | Triggers an Emergency Pack | => No |
| 2021-02-22 21:45 | gorka_gil | Reproducibility | N/A => always |
| 2021-02-22 21:45 | gorka_gil | Steps to Reproduce Updated | View Revisions |
| 2021-02-22 21:53 | hgbot | Merge Request Status | => open |
| 2021-02-22 21:53 | hgbot | Note Added: 0126281 | |
| 2021-02-24 10:44 | hgbot | Merge Request Status | open => approved |
| 2021-02-24 10:44 | hgbot | Resolution | open => fixed |
| 2021-02-24 10:44 | hgbot | Status | new => closed |
| 2021-02-24 10:44 | hgbot | Note Added: 0126316 | |
| 2021-02-24 10:44 | hgbot | Fixed in Version | => PR21Q2 |
| 2021-02-24 10:44 | hgbot | Note Added: 0126317 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |