Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0045936Openbravo ERPA. Platformpublic2021-02-22 21:442021-02-24 10:44
gorka_gil 
gorka_gil 
normaltrivialalways
closedfixed 
5
 
PR21Q2 
Core
No
0045936: eslint git hook fails to execute in systems without realpath
In operating systems like macOS that don't have realpath,
the git hook of eslint fails to execute.

Error message:

pre-commit: Performing lint check on modified js resources
Checking npm and required packages are installed...
Npm and all required tools are installed. Done!

Oops! Something went wrong! :(

ESLint: 7.17.0

No files matching the pattern "GIT" were found.
Please check for typing mistakes in the pattern.
In macOS,
add the git hook of eslint (http://wiki.openbravo.com/wiki/JavaScript_Coding_Conventions#Git_hooks [^])
modify a js file that has the new formatting, for example:
   in mobile.core: web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
and try to do a commit
No tags attached.
Issue History
2021-02-22 21:44gorka_gilNew Issue
2021-02-22 21:44gorka_gilAssigned To => gorka_gil
2021-02-22 21:44gorka_gilModules => Core
2021-02-22 21:44gorka_gilTriggers an Emergency Pack => No
2021-02-22 21:45gorka_gilReproducibilityN/A => always
2021-02-22 21:45gorka_gilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22138#r22138
2021-02-22 21:53hgbotNote Added: 0126281
2021-02-24 10:44hgbotResolutionopen => fixed
2021-02-24 10:44hgbotStatusnew => closed
2021-02-24 10:44hgbotNote Added: 0126316
2021-02-24 10:44hgbotFixed in Version => PR21Q2
2021-02-24 10:44hgbotNote Added: 0126317

Notes
(0126281)
hgbot   
2021-02-22 21:53   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/319 [^]
(0126316)
hgbot   
2021-02-24 10:44   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/319 [^]
(0126317)
hgbot   
2021-02-24 10:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 217fa1e2107666bb045033dfb44933d929e5069a
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-02-24T09:44:11+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/217fa1e2107666bb045033dfb44933d929e5069a [^]

Fixes ISSUE-45936: Fix jslint for operating systems that don't have realpath

This apply for example to macOS

---
M modules/org.openbravo.client.kernel/jslint/jslint
---