0045871: Void Layaway ticket stuck in EWI with error "This order contains not fully delivered line(s) with deferred services related"

From 16ea8ac2986a34a04859c1ee3584618f539b246c Mon Sep 17 00:00:00 2001
From: Rafael Queralta <rafaelcuba81@gmail.com>
Date: Tue, 16 Feb 2021 12:18:58 -0500
Subject: [PATCH] Fixed BUG-45871: Added the same validation for deferred
 services of Cancel Layaway in Void Layaway

---
 src-db/database/sourcedata/AD_MESSAGE.xml     | 12 +++++
 .../js/components/menu.js                     | 48 ++++++++++++++++++-
 2 files changed, 59 insertions(+), 1 deletion(-)

diff --git a/src-db/database/sourcedata/AD_MESSAGE.xml b/src-db/database/sourcedata/AD_MESSAGE.xml
index 0c8bd84d1..72a971c3f 100644
--- a/src-db/database/sourcedata/AD_MESSAGE.xml
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml
@@ -6832,6 +6832,18 @@ Are you sure you want to use %0 of %1 's credit to complete this receipt?]]></MS
 <!--8485715DADF24D22979D91FC2299B575-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
 <!--8485715DADF24D22979D91FC2299B575--></AD_MESSAGE>
 
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21--><AD_MESSAGE>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <AD_MESSAGE_ID><![CDATA[84999BF4F52C4AB29DDDDDD4D40A1F21]]></AD_MESSAGE_ID>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <VALUE><![CDATA[OBPOS_CannotVoidLayWithDeferred]]></VALUE>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <MSGTEXT><![CDATA[This order contains not fully delivered line(s) with deferred services related. Is not possible to void layaway which has related services. Cancel the service before voiding this layaway.]]></MSGTEXT>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
+<!--84999BF4F52C4AB29DDDDDD4D40A1F21--></AD_MESSAGE>
+
 <!--849E52825027454DA2FFA882AA093614--><AD_MESSAGE>
 <!--849E52825027454DA2FFA882AA093614-->  <AD_MESSAGE_ID><![CDATA[849E52825027454DA2FFA882AA093614]]></AD_MESSAGE_ID>
 <!--849E52825027454DA2FFA882AA093614-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff --git a/web/org.openbravo.retail.posterminal/js/components/menu.js b/web/org.openbravo.retail.posterminal/js/components/menu.js
index f1fbcc736..8bd8fc6de 100644
--- a/web/org.openbravo.retail.posterminal/js/components/menu.js
+++ b/web/org.openbravo.retail.posterminal/js/components/menu.js
@@ -35,7 +35,53 @@ enyo.kind({
       return true;
     }
     this.inherited(arguments); // Manual dropdown menu closure
-    this.model.get('order').checkNotProcessedPayments(function() {
+    function checkNotDeliveredDeferredServices(callback) {
+      var receipt = OB.MobileApp.model.receipt;
+      receipt.checkNotProcessedPayments(function() {
+        receipt.canCancelOrder(
+          null,
+          {
+            checkNotDeliveredDeferredServices: true
+          },
+          function(data) {
+            if (
+              data &&
+              data.notDeliveredDeferredServices &&
+              data.notDeliveredDeferredServices.length
+            ) {
+              var components = [];
+              components.push({
+                content: OB.I18N.getLabel('OBPOS_CannotVoidLayWithDeferred'),
+                classes:
+                  'confirmationPopup-body_cannotCancelLayWithDeferred confirmationPopup-body_generic'
+              });
+              components.push({
+                content: OB.I18N.getLabel('OBPOS_RelatedOrders'),
+                classes:
+                  'confirmationPopup-body_relatedOrders confirmationPopup-body_generic'
+              });
+              _.each(data.notDeliveredDeferredServices, function(documentNo) {
+                components.push({
+                  content:
+                    OB.I18N.getLabel('OBMOBC_Character')[1] + ' ' + documentNo,
+                  classes:
+                    'confirmationPopup-body_character confirmationPopup-body_generic'
+                });
+              });
+              OB.UTIL.showConfirmation.display(
+                OB.I18N.getLabel('OBMOBC_Error'),
+                components
+              );
+            } else {
+              if (callback) {
+                callback();
+              }
+            }
+          }
+        );
+      });
+    }
+    checkNotDeliveredDeferredServices(function() {
       OB.UTIL.HookManager.executeHooks(
         'OBPOS_PreVoidLayaway',
         {
-- 
2.25.1