Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045732 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Retail Modules] Web POS | major | N/A | 2021-01-14 13:53 | 2021-02-04 17:31 | |||
| Reporter | gorka_gil | View Status | public | |||||
| Assigned To | gorka_gil | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045732: Extract from Terminal Log actions the code dependent of enyo | |||||||
| Description | The terminal log actions are shared between the old pos and new one, so inside can not be code dependent of enyo or react. | |||||||
| Steps To Reproduce | For example this code to calculate the button clicked name, it is dependant of enyo objects structure: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js#L106 [^] | |||||||
| Proposed Solution | Extract all this enyo dependent code, outside of the actions code, and pass to the action as parameter | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0125561) hgbot (developer) 2021-01-19 00:19 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/133 [^] |
|
(0125779) hgbot (developer) 2021-01-26 11:23 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/133 [^] |
|
(0125780) hgbot (developer) 2021-01-26 11:23 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: f74dc6e1b8d16d699ea646c7e128517987924629 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-01-26T10:23:13+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/f74dc6e1b8d16d699ea646c7e128517987924629 [^] Fixes ISSUE-45732: Extract all enyo dependent code from terminal log actions --- A web/org.openbravo.mobile.core/source/utils/terminal-log-utils-enyo-dependent.js M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddButtonClick.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddKey.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddLog.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddProcess.js M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js M web/org.openbravo.mobile.core/source/utils/ob-dom-extension.js M web/org.openbravo.mobile.core/source/utils/terminal-log-sync-utils.js --- |
|
(0125781) hgbot (developer) 2021-01-26 11:23 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 493e957e294d3bf18a3db506ed8ac4b511a8d085 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-01-26T10:23:13+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/493e957e294d3bf18a3db506ed8ac4b511a8d085 [^] Related to ISSUE-45732: replace deprecated srcElement --- M web/org.openbravo.mobile.core/source/utils/ob-dom-extension.js --- |
|
(0125782) hgbot (developer) 2021-01-26 11:23 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: a5e60eb894cb0d935eaef373ac91fc812b42ba79 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-01-26T10:23:13+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/a5e60eb894cb0d935eaef373ac91fc812b42ba79 [^] Related to ISSUE-45732: Adapt jest tests --- M web-test/model/business-object/terminal-log/TerminalLog-AddButtonClick-ActionPreparation.test.js M web-test/model/business-object/terminal-log/TerminalLog-Addkey-ActionPreparation.test.js M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddbuttonClick.test.js M web-test/model/business-object/terminal-log/TerminalLog-StateAction-Addkey.test.js --- |
|
(0125785) hgbot (developer) 2021-01-26 11:23 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 3ec498c3e6040382447874ad6b273eba810fcbee Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-01-26T10:23:13+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/3ec498c3e6040382447874ad6b273eba810fcbee [^] Related to ISSUE-45648, related to ISSUE-45732: move context calculation to a diferent action preparation This action preparation will be only executed in the old pos, in the new pos it will be replaced with another action preparation that will have another way to calculate the context --- A web/org.openbravo.mobile.core/source/utils/terminal-log-calculate-context-action-preparation.js M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddLog.test.js M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddProcess.test.js M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddbuttonClick.test.js M web-test/model/business-object/terminal-log/TerminalLog-StateAction-Addkey.test.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddButtonClick.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddKey.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddLog.js M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddProcess.js --- |
|
(0125917) hgbot (developer) 2021-02-01 12:16 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 0002b0514773b518f1af8bdc5609175f40c7da81 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-01T11:16:14+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/0002b0514773b518f1af8bdc5609175f40c7da81 [^] Related to ISSUE-45732: move context action preparation to pos It uses ticket id so it needs to be in pos instead of core --- M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java M web/org.openbravo.mobile.core/source/utils/terminal-log-utils-enyo-dependent.js R web/org.openbravo.mobile.core/source/utils/terminal-log-calculate-context-action-preparation.js --- |
|
(0125918) hgbot (developer) 2021-02-01 12:16 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 3f960d57423598fc815dff62fa266170eadfe4eb Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-01T11:16:29+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3f960d57423598fc815dff62fa266170eadfe4eb [^] Related to ISSUE-45732: move context action preparation to pos It uses ticket id so it needs to be in pos instead of core --- A web/org.openbravo.retail.posterminal/js/utils/terminal-log-context.js M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java --- |
|
(0125984) hgbot (developer) 2021-02-04 17:31 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 9e5c49a10f8efea8b8c9cd091b16c8ac270657eb Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-03T22:54:17+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9e5c49a10f8efea8b8c9cd091b16c8ac270657eb [^] Related to ISSUE-45732: fix terminal log in awo Move back the logic of calculate context to mobile.core making option the ticketid And create a action preparation in pos to set that ticketid --- A web/org.openbravo.mobile.core/source/utils/terminal-log-context.js M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java --- |
|
(0125985) hgbot (developer) 2021-02-04 17:31 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 32c1bb32e0a8b783d185d76838e06e9f00510c8f Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-03T22:54:17+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/32c1bb32e0a8b783d185d76838e06e9f00510c8f [^] Related to ISSUE-45732: log the error when fails the TerminalLogLoader --- M src/org/openbravo/mobile/core/TerminalLogLoader.java --- |
|
(0125986) hgbot (developer) 2021-02-04 17:31 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 7d34f5fef0bc33ddcb6066c3f172635267de261d Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-03T22:54:17+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7d34f5fef0bc33ddcb6066c3f172635267de261d [^] Related to ISSUE-45732: move missing terminal log pos related things to pos module --- M web/org.openbravo.mobile.core/source/utils/terminal-log-context.js --- |
|
(0125987) hgbot (developer) 2021-02-04 17:31 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 92d4f102c0e3789538dd4ea55c16bc7d9d9da9ee Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-04T16:31:13+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/92d4f102c0e3789538dd4ea55c16bc7d9d9da9ee [^] Related to ISSUE-45732: fix terminal log in awo Move back the logic of calculate context to mobile.core making option the ticketid And create a action preparation in pos to set that ticketid --- M web/org.openbravo.retail.posterminal/js/utils/terminal-log-context.js --- |
|
(0125988) hgbot (developer) 2021-02-04 17:31 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: b42b5d611e4911a0a1bdb7fb1b97649ff2bad4d7 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2021-02-04T16:31:13+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b42b5d611e4911a0a1bdb7fb1b97649ff2bad4d7 [^] Related to ISSUE-45732: move missing terminal log pos related things to pos module --- M web/org.openbravo.retail.posterminal/js/utils/terminal-log-context.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-01-14 13:53 | gorka_gil | New Issue | |
| 2021-01-14 13:53 | gorka_gil | Assigned To | => gorka_gil |
| 2021-01-14 13:53 | gorka_gil | Triggers an Emergency Pack | => No |
| 2021-01-14 14:08 | gorka_gil | Relationship added | related to 0043288 |
| 2021-01-19 00:19 | hgbot | Note Added: 0125561 | |
| 2021-01-19 10:18 | gorka_gil | Status | new => scheduled |
| 2021-01-26 11:23 | hgbot | Resolution | open => fixed |
| 2021-01-26 11:23 | hgbot | Status | scheduled => closed |
| 2021-01-26 11:23 | hgbot | Note Added: 0125779 | |
| 2021-01-26 11:23 | hgbot | Fixed in Version | => RR21Q2 |
| 2021-01-26 11:23 | hgbot | Note Added: 0125780 | |
| 2021-01-26 11:23 | hgbot | Note Added: 0125781 | |
| 2021-01-26 11:23 | hgbot | Note Added: 0125782 | |
| 2021-01-26 11:23 | hgbot | Note Added: 0125785 | |
| 2021-02-01 12:16 | hgbot | Note Added: 0125917 | |
| 2021-02-01 12:16 | hgbot | Note Added: 0125918 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125984 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125985 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125986 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125987 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125988 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |