Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0045732 | Retail Modules | Web POS | public | 2021-01-14 13:53 | 2021-02-04 17:31 |
|
| Reporter | gorka_gil | |
| Assigned To | gorka_gil | |
| Priority | normal | Severity | major | Reproducibility | N/A |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR21Q2 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0045732: Extract from Terminal Log actions the code dependent of enyo |
| Description | The terminal log actions are shared between the old pos and new one, so inside can not be code dependent of enyo or react. |
| Steps To Reproduce | For example this code to calculate the button clicked name, it is dependant of enyo objects structure:
https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js#L106 [^] |
| Proposed Solution | Extract all this enyo dependent code, outside of the actions code, and pass to the action as parameter |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | feature request | 0043288 | | closed | marvintm | Implement StateController and SynchronizationBuffer components using IndexedDB |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-01-14 13:53 | gorka_gil | New Issue | |
| 2021-01-14 13:53 | gorka_gil | Assigned To | => gorka_gil |
| 2021-01-14 13:53 | gorka_gil | Triggers an Emergency Pack | => No |
| 2021-01-14 14:08 | gorka_gil | Relationship added | related to 0043288 |
| 2021-01-19 00:19 | hgbot | Note Added: 0125561 | |
| 2021-01-19 10:18 | gorka_gil | Status | new => scheduled |
| 2021-01-26 11:23 | hgbot | Resolution | open => fixed |
| 2021-01-26 11:23 | hgbot | Status | scheduled => closed |
| 2021-01-26 11:23 | hgbot | Note Added: 0125779 | |
| 2021-01-26 11:23 | hgbot | Fixed in Version | => RR21Q2 |
| 2021-01-26 11:23 | hgbot | Note Added: 0125780 | |
| 2021-01-26 11:23 | hgbot | Note Added: 0125781 | |
| 2021-01-26 11:23 | hgbot | Note Added: 0125782 | |
| 2021-01-26 11:23 | hgbot | Note Added: 0125785 | |
| 2021-02-01 12:16 | hgbot | Note Added: 0125917 | |
| 2021-02-01 12:16 | hgbot | Note Added: 0125918 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125984 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125985 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125986 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125987 | |
| 2021-02-04 17:31 | hgbot | Note Added: 0125988 | |
|
Notes |
|
|
(0125561)
|
|
hgbot
|
|
2021-01-19 00:19
|
|
|
|
|
(0125779)
|
|
hgbot
|
|
2021-01-26 11:23
|
|
|
|
|
(0125780)
|
|
hgbot
|
|
2021-01-26 11:23
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: f74dc6e1b8d16d699ea646c7e128517987924629
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-01-26T10:23:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/f74dc6e1b8d16d699ea646c7e128517987924629 [^]
Fixes ISSUE-45732: Extract all enyo dependent code from terminal log actions
---
A web/org.openbravo.mobile.core/source/utils/terminal-log-utils-enyo-dependent.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddButtonClick.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddKey.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddLog.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddProcess.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-dom-extension.js
M web/org.openbravo.mobile.core/source/utils/terminal-log-sync-utils.js
---
|
|
|
|
(0125781)
|
|
hgbot
|
|
2021-01-26 11:23
|
|
|
|
|
(0125782)
|
|
hgbot
|
|
2021-01-26 11:23
|
|
|
|
|
(0125785)
|
|
hgbot
|
|
2021-01-26 11:23
|
|
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 3ec498c3e6040382447874ad6b273eba810fcbee
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-01-26T10:23:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/3ec498c3e6040382447874ad6b273eba810fcbee [^]
Related to ISSUE-45648, related to ISSUE-45732: move context calculation to a diferent action preparation
This action preparation will be only executed in the old pos,
in the new pos it will be replaced with another action preparation
that will have another way to calculate the context
---
A web/org.openbravo.mobile.core/source/utils/terminal-log-calculate-context-action-preparation.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddLog.test.js
M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddProcess.test.js
M web-test/model/business-object/terminal-log/TerminalLog-StateAction-AddbuttonClick.test.js
M web-test/model/business-object/terminal-log/TerminalLog-StateAction-Addkey.test.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddButtonClick.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddKey.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddLog.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddProcess.js
---
|
|
|
|
(0125917)
|
|
hgbot
|
|
2021-02-01 12:16
|
|
|
|
|
(0125918)
|
|
hgbot
|
|
2021-02-01 12:16
|
|
|
|
|
(0125984)
|
|
hgbot
|
|
2021-02-04 17:31
|
|
|
|
|
(0125985)
|
|
hgbot
|
|
2021-02-04 17:31
|
|
|
|
|
(0125986)
|
|
hgbot
|
|
2021-02-04 17:31
|
|
|
|
|
(0125987)
|
|
hgbot
|
|
2021-02-04 17:31
|
|
|
|
|
(0125988)
|
|
hgbot
|
|
2021-02-04 17:31
|
|
|