0045656: WebPOS fails with Chrome v89, because of new .at() function in Strings

Description

In Chrome v89, the String prototype has a new at() function. This is a problem with the current implementation of the WebPOS, because the .at function is used to distinguish between Backbone collections and other types of objects.

Steps To Reproduce

Using Chrome Dev branch, log in the WebPOS. Realise the following Javascript error is raised:

Uncaught (in promise) TypeError: clonedObject.get(...).reset is not a function
    at 54efdf8ddc7966329ee58389bd8dd37b.js:14770
    at Array.forEach (<anonymous>)
    at Function.b.each.b.forEach (underscore-1.3.3.min.js:11)
    at cloneRecursively (54efdf8ddc7966329ee58389bd8dd37b.js:14762)
    at Object.OB.UTIL.clone (54efdf8ddc7966329ee58389bd8dd37b.js:14849)
    at G.d.clearWith (54efdf8ddc7966329ee58389bd8dd37b.js:66024)
    at Object.OB.UTIL.TicketUtils.loadAndSyncTicketFromState (54efdf8ddc7966329ee58389b

Proposed Solution

Instead of checking the .at() function, it should be checked whether the object is instance of Backbone.Collection.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0045655

closed

ranjith_qualiantech_com

WebPOS fails with Chrome v89, because of new .at() function in Strings

Notes
(0125121) hgbot (developer) 2020-12-29 07:47	Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 26935482d4f3a00802f7fd2f1ff710d747ccfa86 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-12-29T12:16:59+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/26935482d4f3a00802f7fd2f1ff710d747ccfa86 [^] Fixed ISSUE-45656: Replace Object validation with Backbone instance when cloning object --- M web/org.openbravo.mobile.core/source/utils/ob-utilities.js ---

Issue History
Date Modified	Username	Field	Change
2020-12-28 16:04	marvintm	Type	defect => backport
2020-12-28 16:04	marvintm	Target Version	=> RR20Q4.1
2020-12-29 07:47	hgbot	Resolution	open => fixed
2020-12-29 07:47	hgbot	Status	scheduled => resolved
2020-12-29 07:47	hgbot	Fixed in Version	=> RR20Q4.1
2020-12-29 07:47	hgbot	Note Added: 0125121
2020-12-29 08:12	marvintm	Review Assigned To	=> marvintm
2020-12-29 08:12	marvintm	Status	resolved => closed