Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045656Retail ModulesWeb POSpublic2020-12-28 16:042020-12-29 08:12
marvintm 
ranjith_qualiantech_com 
normalcriticalhave not tried
closedfixed 
5
 
RR20Q4.1RR20Q4.1 
marvintm
No
0045656: WebPOS fails with Chrome v89, because of new .at() function in Strings
In Chrome v89, the String prototype has a new at() function. This is a problem with the current implementation of the WebPOS, because the .at function is used to distinguish between Backbone collections and other types of objects.
Using Chrome Dev branch, log in the WebPOS. Realise the following Javascript error is raised:

Uncaught (in promise) TypeError: clonedObject.get(...).reset is not a function
    at 54efdf8ddc7966329ee58389bd8dd37b.js:14770
    at Array.forEach (<anonymous>)
    at Function.b.each.b.forEach (underscore-1.3.3.min.js:11)
    at cloneRecursively (54efdf8ddc7966329ee58389bd8dd37b.js:14762)
    at Object.OB.UTIL.clone (54efdf8ddc7966329ee58389bd8dd37b.js:14849)
    at G.d.clearWith (54efdf8ddc7966329ee58389bd8dd37b.js:66024)
    at Object.OB.UTIL.TicketUtils.loadAndSyncTicketFromState (54efdf8ddc7966329ee58389b

Instead of checking the .at() function, it should be checked whether the object is instance of Backbone.Collection.
No tags attached.
blocks defect 0045655 closed ranjith_qualiantech_com WebPOS fails with Chrome v89, because of new .at() function in Strings 
Issue History
2020-12-28 16:04marvintmTypedefect => backport
2020-12-28 16:04marvintmTarget Version => RR20Q4.1
2020-12-29 07:47hgbotResolutionopen => fixed
2020-12-29 07:47hgbotStatusscheduled => resolved
2020-12-29 07:47hgbotFixed in Version => RR20Q4.1
2020-12-29 07:47hgbotNote Added: 0125121
2020-12-29 08:12marvintmReview Assigned To => marvintm
2020-12-29 08:12marvintmStatusresolved => closed

Notes
(0125121)
hgbot   
2020-12-29 07:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 26935482d4f3a00802f7fd2f1ff710d747ccfa86
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-29T12:16:59+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/26935482d4f3a00802f7fd2f1ff710d747ccfa86 [^]

Fixed ISSUE-45656: Replace Object validation with Backbone instance when cloning object

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---