|View Issue Details|
|Type||Category||Severity||Reproducibility||Date Submitted||Last Update|
|defect||[Openbravo ERP] 07. Sales management||major||always||2020-12-22 22:50||2021-03-08 13:38|
|Priority||normal||Resolution||fixed||Fixed in Version||PR21Q2|
|Status||closed||Fix in branch||Fixed in SCM revision|
|OS Version||Database version||Ant version|
|Product Version||SCM revision|
|Review Assigned To|
|Modules||Advanced Payables and Receivables Mngmt|
|Regression introduced in release|
|Regression introduced by commit|
|Triggers an Emergency Pack||No|
0045641: Overpayment action selector appears by scrolling down
|Description||When click on add payment in a booked order, the overpayment action selector appears by scrolling down quickly in the pop up.|
It seems that the logic for displaying this selector is affected by scroll.
See the attached video.
|Steps To Reproduce||1) Go to sales order windows.|
2) Create an order.
3) Book the order.
3) Click on add payment button.
4) Scroll down in the popup just when it appear.
|Tags||No tags attached.|
|Attached Files||Overpayment.mp4 [^] (2,031,229 bytes) 2020-12-22 22:50|
We are not able to reproduce the issue. When I open the window the Add Payment process the field is shown at first, but then hidden within the first second. I see there are four requests to org.openbravo.advpaymentmngt.actionHandler.AddPaymentDisplayLogicActionHandler, the first three determine the field should be shown, the last one that it should be hidden.
We tried with Chrome and Firefox, in a couple of Openbravo releases. What browser did you use, and using what Openbravo release?
We are using Openbravo 20Q3.2 and 20Q4 in Chrome 87
The problem is when scroll down just after the popup appear.
Any update about this?
I am sorry but still I am not able to reproduce it. All the times I try it, at first the field is shown, but once the row is selected the field is hidden. Can we schedule a brief meeting to try to reproduce it together?
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/317 [^]
1. Resize browser to a small size
2. Create a new sales order and enter any line. Book it.
3. Press the Add Payment button
4. Scroll down as fast as possible
5. Verify the Overpayment action selector is hidden
6. Increase the payment amount
7. Verify the Overpayment action selector is shown.
8. Set the payment amount back to the order's grand total amount
9. Verify the Overpayment action selector is hidden
Repeat this exercise in other windows from which the add payment process is shown (like Sales/Purchase Invoice, Payment In/Out, etc.)
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/317 [^]
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Author: Víctor Martínez Romanos <email@example.com>
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d8fbcdeae44bcdab5929400073c6d0c86c1730b5 [^]
Fixed BUG-45641: Overpayment action selector appears by scrolling down
Embed call to AddPaymentDisplayLogicActionHandler inside a fireOnPause() to avoid race condition.
It was observed that before the fix there were 4 calls to this handler, where usually the output was:
Y, Y, Y, N, which is the correct, as the last response is N. However, there were cases where the last
response was Y, making the field wrongly visible.
After this changeset it has been observed that just one call is done, with output N.
|2020-12-22 22:50||lbressan||New Issue|
|2020-12-22 22:50||lbressan||Assigned To||=> Triage Finance|
|2020-12-22 22:50||lbressan||File Added: Overpayment.mp4|
|2020-12-22 22:50||lbressan||Modules||=> Advanced Payables and Receivables Mngmt|
|2020-12-22 22:50||lbressan||Triggers an Emergency Pack||=> No|
|2020-12-29 08:43||vmromanos||Assigned To||Triage Finance => platform|
|2020-12-29 09:54||AugustoMauch||Note Added: 0125129|
|2020-12-29 09:54||AugustoMauch||Assigned To||platform => lbressan|
|2020-12-29 09:54||AugustoMauch||Status||new => feedback|
|2020-12-31 14:19||lbressan||Note Added: 0125233|
|2021-01-21 18:37||lbressan||Note Added: 0125717|
|2021-01-21 18:37||lbressan||Assigned To||lbressan =>|
|2021-01-21 18:38||lbressan||Assigned To||=> AugustoMauch|
|2021-01-26 16:29||egoitz||Status||feedback => new|
|2021-02-09 17:58||AugustoMauch||Note Added: 0126060|
|2021-02-09 17:58||AugustoMauch||Status||new => feedback|
|2021-02-16 11:23||AugustoMauch||Assigned To||AugustoMauch => lbressan|
|2021-02-17 18:18||lbressan||Assigned To||lbressan => AugustoMauch|
|2021-02-17 19:05||AugustoMauch||Assigned To||AugustoMauch => Triage Finance|
|2021-02-17 19:05||AugustoMauch||Status||feedback => new|
|2021-02-18 14:36||vmromanos||Assigned To||Triage Finance => vmromanos|
|2021-02-18 14:36||vmromanos||Status||new => acknowledged|
|2021-02-19 08:40||hgbot||Note Added: 0126199|
|2021-02-19 09:06||vmromanos||Note Added: 0126200|
|2021-02-19 09:06||vmromanos||Status||acknowledged => scheduled|
|2021-03-08 13:38||hgbot||Resolution||open => fixed|
|2021-03-08 13:38||hgbot||Status||scheduled => closed|
|2021-03-08 13:38||hgbot||Note Added: 0126553|
|2021-03-08 13:38||hgbot||Fixed in Version||=> PR21Q2|
|2021-03-08 13:38||hgbot||Note Added: 0126554|
|Copyright © 2000 - 2009 MantisBT Group|