Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045641Openbravo ERP07. Sales managementpublic2020-12-22 22:502021-03-08 13:38
Reporterlbressan 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045641: Overpayment action selector appears by scrolling down
DescriptionWhen click on add payment in a booked order, the overpayment action selector appears by scrolling down quickly in the pop up.

It seems that the logic for displaying this selector is affected by scroll.

See the attached video.
Steps To Reproduce1) Go to sales order windows.
2) Create an order.
3) Book the order.
3) Click on add payment button.
4) Scroll down in the popup just when it appear.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? Overpayment.mp4 (2,031,229) 2020-12-22 22:50
https://issues.openbravo.com/file_download.php?file_id=15205&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-12-22 22:50lbressanNew Issue
2020-12-22 22:50lbressanAssigned To => Triage Finance
2020-12-22 22:50lbressanFile Added: Overpayment.mp4
2020-12-22 22:50lbressanModules => Advanced Payables and Receivables Mngmt
2020-12-22 22:50lbressanTriggers an Emergency Pack => No
2020-12-29 08:43vmromanosAssigned ToTriage Finance => platform
2020-12-29 09:54AugustoMauchNote Added: 0125129
2020-12-29 09:54AugustoMauchAssigned Toplatform => lbressan
2020-12-29 09:54AugustoMauchStatusnew => feedback
2020-12-31 14:19lbressanNote Added: 0125233
2021-01-21 18:37lbressanNote Added: 0125717
2021-01-21 18:37lbressanAssigned Tolbressan =>
2021-01-21 18:38lbressanAssigned To => AugustoMauch
2021-01-26 16:29egoitzStatusfeedback => new
2021-02-04 15:49egoitzResolution time => 1612911600
2021-02-09 17:58AugustoMauchNote Added: 0126060
2021-02-09 17:58AugustoMauchStatusnew => feedback
2021-02-16 11:23AugustoMauchAssigned ToAugustoMauch => lbressan
2021-02-17 18:18lbressanAssigned Tolbressan => AugustoMauch
2021-02-17 19:05AugustoMauchAssigned ToAugustoMauch => Triage Finance
2021-02-17 19:05AugustoMauchStatusfeedback => new
2021-02-18 14:36vmromanosAssigned ToTriage Finance => vmromanos
2021-02-18 14:36vmromanosStatusnew => acknowledged
2021-02-19 08:40hgbotNote Added: 0126199
2021-02-19 09:06vmromanosNote Added: 0126200
2021-02-19 09:06vmromanosStatusacknowledged => scheduled
2021-03-08 13:38hgbotResolutionopen => fixed
2021-03-08 13:38hgbotStatusscheduled => closed
2021-03-08 13:38hgbotNote Added: 0126553
2021-03-08 13:38hgbotFixed in Version => PR21Q2
2021-03-08 13:38hgbotNote Added: 0126554

Notes
(0125129)
AugustoMauch   
2020-12-29 09:54   
Hello,

We are not able to reproduce the issue. When I open the window the Add Payment process the field is shown at first, but then hidden within the first second. I see there are four requests to org.openbravo.advpaymentmngt.actionHandler.AddPaymentDisplayLogicActionHandler, the first three determine the field should be shown, the last one that it should be hidden.

We tried with Chrome and Firefox, in a couple of Openbravo releases. What browser did you use, and using what Openbravo release?
(0125233)
lbressan   
2020-12-31 14:19   
Hello

We are using Openbravo 20Q3.2 and 20Q4 in Chrome 87

The problem is when scroll down just after the popup appear.
(0125717)
lbressan   
2021-01-21 18:37   
Hi

Any update about this?

Regards
(0126060)
AugustoMauch   
2021-02-09 17:58   
Hello,

I am sorry but still I am not able to reproduce it. All the times I try it, at first the field is shown, but once the row is selected the field is hidden. Can we schedule a brief meeting to try to reproduce it together?
(0126199)
hgbot   
2021-02-19 08:40   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/317 [^]
(0126200)
vmromanos   
2021-02-19 09:06   
Test plan:

1. Resize browser to a small size
2. Create a new sales order and enter any line. Book it.
3. Press the Add Payment button
4. Scroll down as fast as possible
5. Verify the Overpayment action selector is hidden
6. Increase the payment amount
7. Verify the Overpayment action selector is shown.
8. Set the payment amount back to the order's grand total amount
9. Verify the Overpayment action selector is hidden

Repeat this exercise in other windows from which the add payment process is shown (like Sales/Purchase Invoice, Payment In/Out, etc.)
(0126553)
hgbot   
2021-03-08 13:38   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/317 [^]
(0126554)
hgbot   
2021-03-08 13:38   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d8fbcdeae44bcdab5929400073c6d0c86c1730b5
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-03-08T12:26:40+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d8fbcdeae44bcdab5929400073c6d0c86c1730b5 [^]

Fixed BUG-45641: Overpayment action selector appears by scrolling down

Embed call to AddPaymentDisplayLogicActionHandler inside a fireOnPause() to avoid race condition.

It was observed that before the fix there were 4 calls to this handler, where usually the output was:
Y, Y, Y, N, which is the correct, as the last response is N. However, there were cases where the last
response was Y, making the field wrongly visible.

After this changeset it has been observed that just one call is done, with output N.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---