Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045414
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-11-10 22:362020-11-11 07:15
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionPR21Q1
StatusclosedFix in branchFixed in SCM revision9de923c9c193
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045414: Skip AccessLevelTest.testADataAccessLevel also for views

Descriptionthe testADataAccessLevel test iterates over all entities and tries to query them to verify ad_client/ad_org values of the resulting rows.

The testcase already skips entities not being a real 'database table':
- isDataSourceBased
- isHQLBased

      if (e.isDataSourceBased() || e.isHQLBased()) {
        // The entity is not associated with a database table, so it does not apply

With the same argumentation probably entities with isView() (having underlying database view's should be skipped)

Concrete failing example:
- custom view calling a database function depending on config/masterdata setup to even work

Current output:
- org.hibernate.exception.GenericJDBCException: could not extract ResultSet
- Inside stacktrace it points to date-setup problem
Caused by: org.postgresql.util.PSQLException: ERROR: @NoConversionRate@ (MXN-$) @to@ (EUR-€) @ForDate@ '11-11-2020', @Client@ 'QA Testing' @And@ @ACCS_AD_ORG_ID_D@ 'USA'.
  Where: PL/pgSQL function c_currency_convert(numeric,character varying,character varying,timestamp without time zone,character varying,character varying,character varying) line 38 at RAISE

Apart from maybe skipping views the testcase does not help at all to point to the entity having the issue.

Attached patch skips views + adds some context (entityName) to any exception thrown while running a query.
Steps To ReproduceNoticed in a customer/project instance (ask reporter is needed for a concrete example)
TagsNo tags attached.
Attached Filesdiff file icon 45414.diff [^] (2,453 bytes) 2020-11-10 22:37 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0045415PR20Q4 closedshuehner Skip AccessLevelTest.testADataAccessLevel also for views 

-  Notes
(0124264)
shuehner (administrator)
2020-11-10 22:37

Note: attached patch is based on release/20Q4 branch
(0124269)
hgbot (developer)
2020-11-11 07:01

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/222 [^]
(0124270)
hgbot (developer)
2020-11-11 07:06

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/222 [^]
(0124271)
hgbot (developer)
2020-11-11 07:06

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 9de923c9c1932ba7630e06b04d84e6bbbf0aaeba
Author: Stefan Hühner <stefan.huehner@openbravo.com>
Date: 2020-11-11T07:04:29+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/9de923c9c1932ba7630e06b04d84e6bbbf0aaeba [^]

fixed ISSUE-45414: AccessLevelTest.testADataAccessLevel tests on views

While in general testing access level on views is not a problem, there
are some cases when this is problematic as tested view might require on
some extra config which could be not set.

This patch:

  * Skips testing on database views
  * Adds information about the entity that failed in case of an
    exception

---
M src-test/src/org/openbravo/test/security/AccessLevelTest.java
---

- Issue History
Date Modified Username Field Change
2020-11-10 22:36 shuehner New Issue
2020-11-10 22:36 shuehner Assigned To => platform
2020-11-10 22:36 shuehner Modules => Core
2020-11-10 22:36 shuehner Triggers an Emergency Pack => No
2020-11-10 22:37 shuehner File Added: 45414.diff
2020-11-10 22:37 shuehner Note Added: 0124264
2020-11-11 07:01 hgbot Note Added: 0124269
2020-11-11 07:06 alostale Assigned To platform => shuehner
2020-11-11 07:06 hgbot Note Added: 0124270
2020-11-11 07:06 hgbot Resolution open => fixed
2020-11-11 07:06 hgbot Status new => resolved
2020-11-11 07:06 hgbot Fixed in Version => PR21Q1
2020-11-11 07:06 hgbot Note Added: 0124271
2020-11-11 07:07 alostale Review Assigned To => alostale
2020-11-11 07:07 alostale Status resolved => closed
2020-11-11 07:08 alostale Status closed => new
2020-11-11 07:08 alostale Resolution fixed => open
2020-11-11 07:08 alostale Fixed in Version PR21Q1 =>
2020-11-11 07:08 alostale Status new => scheduled
2020-11-11 07:15 alostale Status scheduled => resolved
2020-11-11 07:15 alostale Fixed in Version => PR21Q1
2020-11-11 07:15 alostale Fixed in SCM revision => https://gitlab.com/openbravo/product/openbravo/-/commit/9de923c9c1932ba7630e06b04d84e6bbbf0aaeba [^]
2020-11-11 07:15 alostale Resolution open => fixed
2020-11-11 07:15 alostale Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker