Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045414Openbravo ERPA. Platformpublic2020-11-10 22:362020-11-11 07:15
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045414: Skip AccessLevelTest.testADataAccessLevel also for views
Descriptionthe testADataAccessLevel test iterates over all entities and tries to query them to verify ad_client/ad_org values of the resulting rows.

The testcase already skips entities not being a real 'database table':
- isDataSourceBased
- isHQLBased

      if (e.isDataSourceBased() || e.isHQLBased()) {
        // The entity is not associated with a database table, so it does not apply

With the same argumentation probably entities with isView() (having underlying database view's should be skipped)

Concrete failing example:
- custom view calling a database function depending on config/masterdata setup to even work

Current output:
- org.hibernate.exception.GenericJDBCException: could not extract ResultSet
- Inside stacktrace it points to date-setup problem
Caused by: org.postgresql.util.PSQLException: ERROR: @NoConversionRate@ (MXN-$) @to@ (EUR-€) @ForDate@ '11-11-2020', @Client@ 'QA Testing' @And@ @ACCS_AD_ORG_ID_D@ 'USA'.
  Where: PL/pgSQL function c_currency_convert(numeric,character varying,character varying,timestamp without time zone,character varying,character varying,character varying) line 38 at RAISE

Apart from maybe skipping views the testcase does not help at all to point to the entity having the issue.

Attached patch skips views + adds some context (entityName) to any exception thrown while running a query.
Steps To ReproduceNoticed in a customer/project instance (ask reporter is needed for a concrete example)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045415PR20Q4 closed shuehner Openbravo ERP Skip AccessLevelTest.testADataAccessLevel also for views 
related to defect 0047751 closed vmromanos Localization Pack: Spain Module ssi fails org.openbravo.test.security.AccessLevelTest.testADataAccessLevel junit test 
Attached Filesdiff 45414.diff (2,453) 2020-11-10 22:37
https://issues.openbravo.com/file_download.php?file_id=15076&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-11-10 22:36shuehnerNew Issue
2020-11-10 22:36shuehnerAssigned To => platform
2020-11-10 22:36shuehnerModules => Core
2020-11-10 22:36shuehnerTriggers an Emergency Pack => No
2020-11-10 22:37shuehnerFile Added: 45414.diff
2020-11-10 22:37shuehnerNote Added: 0124264
2020-11-11 07:01hgbotNote Added: 0124269
2020-11-11 07:06alostaleAssigned Toplatform => shuehner
2020-11-11 07:06hgbotNote Added: 0124270
2020-11-11 07:06hgbotResolutionopen => fixed
2020-11-11 07:06hgbotStatusnew => resolved
2020-11-11 07:06hgbotFixed in Version => PR21Q1
2020-11-11 07:06hgbotNote Added: 0124271
2020-11-11 07:07alostaleReview Assigned To => alostale
2020-11-11 07:07alostaleStatusresolved => closed
2020-11-11 07:08alostaleStatusclosed => new
2020-11-11 07:08alostaleResolutionfixed => open
2020-11-11 07:08alostaleFixed in VersionPR21Q1 =>
2020-11-11 07:08alostaleStatusnew => scheduled
2020-11-11 07:15alostaleStatusscheduled => resolved
2020-11-11 07:15alostaleFixed in Version => PR21Q1
2020-11-11 07:15alostaleFixed in SCM revision => https://gitlab.com/openbravo/product/openbravo/-/commit/9de923c9c1932ba7630e06b04d84e6bbbf0aaeba [^]
2020-11-11 07:15alostaleResolutionopen => fixed
2020-11-11 07:15alostaleStatusresolved => closed
2021-09-24 14:52vmromanosRelationship addedrelated to 0047751

Notes
(0124264)
shuehner   
2020-11-10 22:37   
Note: attached patch is based on release/20Q4 branch
(0124269)
hgbot   
2020-11-11 07:01   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/222 [^]
(0124270)
hgbot   
2020-11-11 07:06   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/222 [^]
(0124271)
hgbot   
2020-11-11 07:06   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 9de923c9c1932ba7630e06b04d84e6bbbf0aaeba
Author: Stefan Hühner <stefan.huehner@openbravo.com>
Date: 2020-11-11T07:04:29+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/9de923c9c1932ba7630e06b04d84e6bbbf0aaeba [^]

fixed ISSUE-45414: AccessLevelTest.testADataAccessLevel tests on views

While in general testing access level on views is not a problem, there
are some cases when this is problematic as tested view might require on
some extra config which could be not set.

This patch:

  * Skips testing on database views
  * Adds information about the entity that failed in case of an
    exception

---
M src-test/src/org/openbravo/test/security/AccessLevelTest.java
---