Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0045377

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2020-11-04 17:33

2020-11-20 08:40

Reporter

martinsdan

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

unable to reproduce

Fixed in Version

RR20Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Linux 64 bit

Database

PostgreSQL

Java version

11

OS Version

Ubuntu 18.04.1 LTS

Database version

10.10

Ant version

1.10.5

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0045377: Rounding payment should not be added if the payment is not added

Description

If the rounding feature is configured for a payment and the payment is canceled when inserting, the rounding payment is still added.
If an OBPOS_preAddPayment adds the flag cancellation to true, the original payment is not added but the rounding payment is.

Steps To Reproduce

- Create an OBPOS_preAddPayment hook that adds "args.cancellation = false" if a payment is bigger than 100.
- Add a rounding to the payment method cash
  - Go to Terminal Type | Payment Method
  - Create a new payment method marked as rounding
  - Go to the payment method cash and add a new entry in the subtab Payment Rounding
  - Activate it for sales, Rounding down and "Rounding Multiple in Sales" = 0.05
- Login to the touchpoint
- Add a product that costs 101.23
- Pay it in cash

See that the only payment added is the rounding payment with an amount of 0.03

Proposed Solution

If the flag canceled is true after running all the hooks, the respective rounding payment should be reverted.

Tags

No tags attached.

45377_posterminal_20Q2.diff [^] (1,143 bytes) 2020-11-20 07:57 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
index df8ed3346..92c28dd97 100644
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -7598,10 +7598,6 @@
       payments = this.get('payments');
       precision = this.getPrecision(payment);
       payment.set('amount', OB.DEC.toNumber(payment.get('amount'), precision));
-      this.addPaymentRounding(
-        payment,
-        OB.MobileApp.model.paymentnames[payment.get('kind')]
-      );
 
       if (this.get('prepaymentChangeMode')) {
         this.unset('prepaymentChangeMode');
@@ -7652,6 +7648,10 @@
                 OB.UTIL.ProcessController.finish('addPayment', execution);
                 return;
               }
+              me.addPaymentRounding(
+                payment,
+                OB.MobileApp.model.paymentnames[payment.get('kind')]
+              );
               // search for an existing payment only if is not a reverser payment.
               if (!payment.get('reversedPaymentId')) {
                 if (

45377_posterminal_20Q3.diff [^] (1,144 bytes) 2020-11-20 08:39 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
index 7b152ff95..2572061ec 100644
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -7966,11 +7966,6 @@
       payments = this.get('payments');
       precision = this.getPrecision(payment);
       payment.set('amount', OB.DEC.toNumber(payment.get('amount'), precision));
-      this.addPaymentRounding(
-        payment,
-        OB.MobileApp.model.paymentnames[payment.get('kind')]
-      );
-
       if (this.get('prepaymentChangeMode')) {
         this.unset('prepaymentChangeMode');
         this.adjustPayment();
@@ -8027,6 +8022,10 @@
                 executeFinalCallback(false);
                 return;
               }
+              me.addPaymentRounding(
+                payment,
+                OB.MobileApp.model.paymentnames[payment.get('kind')]
+              );
               // search for an existing payment only if is not a reverser payment.
               if (!payment.get('reversedPaymentId')) {
                 if (

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

RR20Q3.2

closed

ranjith_qualiantech_com

Rounding payment should not be added if the payment is not added

Notes
(0124475) martinsdan (developer) 2020-11-18 11:45	This is reproducible in 20Q2. https://livebuilds.openbravo.com/retail_mp_3.0RR20Q2.2/web/org.openbravo.retail.posterminal/?terminal=VBS1001#retail.pointofsale [^]

(0124518) marvintm (manager) 2020-11-20 08:40	The issue is no longer reproducible in 20Q4 or pi. We have created the backport for 20Q3.2, and we have also attached a patch that should be possible to use in 20Q2 and hopefully earlier versions.

Issue History
Date Modified	Username	Field	Change
2020-11-04 17:33	martinsdan	New Issue
2020-11-04 17:33	martinsdan	Assigned To	=> Retail
2020-11-04 17:33	martinsdan	Resolution time	=> 1605657600
2020-11-04 17:33	martinsdan	Triggers an Emergency Pack	=> No
2020-11-12 09:38	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-11-16 09:13	ranjith_qualiantech_com	Status	new => scheduled
2020-11-18 11:45	martinsdan	Note Added: 0124475
2020-11-19 13:09	ranjith_qualiantech_com	File Added: 45377.diff
2020-11-20 07:57	ranjith_qualiantech_com	File Deleted: 45377.diff
2020-11-20 07:57	ranjith_qualiantech_com	File Added: 45377_posterminal_20Q2.diff
2020-11-20 08:38	marvintm	Status	scheduled => acknowledged
2020-11-20 08:38	marvintm	Status	acknowledged => scheduled
2020-11-20 08:39	ranjith_qualiantech_com	File Added: 45377_posterminal_20Q3.diff
2020-11-20 08:40	marvintm	Review Assigned To	=> marvintm
2020-11-20 08:40	marvintm	Note Added: 0124518
2020-11-20 08:40	marvintm	Status	scheduled => closed
2020-11-20 08:40	marvintm	Resolution	open => unable to reproduce
2020-11-20 08:40	marvintm	Fixed in Version	=> RR20Q4

Copyright © 2000 - 2009 MantisBT Group