Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045469
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2020-11-04 17:332020-11-23 06:34
ReportermartinsdanView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR20Q3.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR20Q3.2
OSLinux 64 bitDatabasePostgreSQLJava version11
OS VersionUbuntu 18.04.1 LTSDatabase version10.10Ant version1.10.5
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045469: Rounding payment should not be added if the payment is not added

DescriptionIf the rounding feature is configured for a payment and the payment is canceled when inserting, the rounding payment is still added.
If an OBPOS_preAddPayment adds the flag cancellation to true, the original payment is not added but the rounding payment is.
Steps To Reproduce- Create an OBPOS_preAddPayment hook that adds "args.cancellation = false" if a payment is bigger than 100.
- Add a rounding to the payment method cash
  - Go to Terminal Type | Payment Method
  - Create a new payment method marked as rounding
  - Go to the payment method cash and add a new entry in the subtab Payment Rounding
  - Activate it for sales, Rounding down and "Rounding Multiple in Sales" = 0.05
- Login to the touchpoint
- Add a product that costs 101.23
- Pay it in cash

See that the only payment added is the rounding payment with an amount of 0.03
Proposed SolutionIf the flag canceled is true after running all the hooks, the respective rounding payment should be reverted.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0045377 closedranjith_qualiantech_com Rounding payment should not be added if the payment is not added 

-  Notes
(0124552)
hgbot (developer)
2020-11-23 04:27

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 299cbcbb854b3b5a1769199748028e5c0a79a422
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-11-23T08:56:48+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/299cbcbb854b3b5a1769199748028e5c0a79a422 [^]

Fixed ISSUE-45469: Payment Rounding should be added after AddPrePayment Hook

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2020-11-20 08:38 marvintm Type defect => backport
2020-11-20 08:38 marvintm Target Version => RR20Q3.2
2020-11-23 04:27 hgbot Resolution open => fixed
2020-11-23 04:27 hgbot Status scheduled => resolved
2020-11-23 04:27 hgbot Fixed in Version => RR20Q3.2
2020-11-23 04:27 hgbot Note Added: 0124552
2020-11-23 06:34 marvintm Review Assigned To => marvintm
2020-11-23 06:34 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker