Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045361
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2020-11-02 18:372020-11-18 16:45
ReporteraaroncaleroView Statuspublic 
Assigned TojavierRodriguez 
PriorityhighResolutionfixedFixed in VersionRR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRR20Q3.1SCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045361: Javascript/Java error generating terminal log for a process when the Processing Scrim is enabled for slow CalculateReceipts

DescriptionIn order to avoid errors in receipt calculations when using slow devices, it is possible to enable a processing scrim while the calculateReceipt is in progress (either using a preference when using a slow device, or using a configuration at touchpoint type level otherwise).
In these cases, if the CalculateReceipt process takes less than one second, a javascript error is raised in 20q2 and 20q3 releases, while in 20q1 the error happens server-side while processing the terminal log.
Steps To ReproduceIn 20q3 or earlier releases:
Log in backend, go to the Touchpoint type window, open the desired record and enable the 'Block screen when processing ticket' checkbox.
Log in webpos, and add a product to the ticket. If the calculateReceipt takes less than a second, an error will be shown in the browser console (if 20q1 or earlier, no error will be shown here, instead check the server log after the terminal log is synchronized).
In these cases, the terminal log is lost (20q3 and q2 only one line of log is lost, in 20q1 and earlier the whole batch is lost)
Proposed SolutionCheck the code here: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js#L432 [^]

The functionality is composed of a pair of calculatingReceipt/calculatedReceipt events.
The execution parameter is only generated if the calculatingReceipt takes more than 1 second.

To easily fix the problem, the calculatedReceipt should check if the process started (execution !== undefined) before calling OB.UTIL.ProcessController.finish.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0051672 closedyogaskarnik RFID will closed automatically after added products 

-  Notes
(0124488)
hgbot (developer)
2020-11-18 16:32

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/190 [^]
(0124489)
hgbot (developer)
2020-11-18 16:45

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/190 [^]
(0124490)
hgbot (developer)
2020-11-18 16:45

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2ad9ab84872857fcf5bff218a5aeee4b61c583ea
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2020-11-18T16:27:02+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2ad9ab84872857fcf5bff218a5aeee4b61c583ea [^]

Fixed ISSUE-45361: Check if execution exist when calculated receipt has finished in slow devices

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---

- Issue History
Date Modified Username Field Change
2020-11-02 18:37 aaroncalero New Issue
2020-11-02 18:37 aaroncalero Assigned To => Retail
2020-11-02 18:37 aaroncalero Resolution time => 1606086000
2020-11-02 18:37 aaroncalero Triggers an Emergency Pack => No
2020-11-17 10:59 javierRodriguez Assigned To Retail => javierRodriguez
2020-11-18 16:32 hgbot Note Added: 0124488
2020-11-18 16:45 hgbot Resolution open => fixed
2020-11-18 16:45 hgbot Status new => closed
2020-11-18 16:45 hgbot Note Added: 0124489
2020-11-18 16:45 hgbot Fixed in Version => RR21Q1
2020-11-18 16:45 hgbot Note Added: 0124490
2023-03-31 15:45 ranjith_qualiantech_com Relationship added related to 0051672
2023-04-11 13:07 adrianromero Relationship replaced has duplicate 0051672


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker