0045361: Javascript/Java error generating terminal log for a process when the Processing Scrim is enabled for slow CalculateReceipts

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045361

Retail Modules

Web POS

public

2020-11-02 18:37

2020-11-18 16:45

Reporter

aaroncalero

Assigned To

javierRodriguez

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

RR20Q3.1

Target Version

Fixed in Version

RR21Q1

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045361: Javascript/Java error generating terminal log for a process when the Processing Scrim is enabled for slow CalculateReceipts

Description

In order to avoid errors in receipt calculations when using slow devices, it is possible to enable a processing scrim while the calculateReceipt is in progress (either using a preference when using a slow device, or using a configuration at touchpoint type level otherwise).
In these cases, if the CalculateReceipt process takes less than one second, a javascript error is raised in 20q2 and 20q3 releases, while in 20q1 the error happens server-side while processing the terminal log.

Steps To Reproduce

In 20q3 or earlier releases:
Log in backend, go to the Touchpoint type window, open the desired record and enable the 'Block screen when processing ticket' checkbox.
Log in webpos, and add a product to the ticket. If the calculateReceipt takes less than a second, an error will be shown in the browser console (if 20q1 or earlier, no error will be shown here, instead check the server log after the terminal log is synchronized).
In these cases, the terminal log is lost (20q3 and q2 only one line of log is lost, in 20q1 and earlier the whole batch is lost)

Proposed Solution

Check the code here: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js#L432 [^]

The functionality is composed of a pair of calculatingReceipt/calculatedReceipt events.
The execution parameter is only generated if the calculatingReceipt takes more than 1 second.

To easily fix the problem, the calculatedReceipt should check if the process started (execution !== undefined) before calling OB.UTIL.ProcessController.finish.

Additional Information