0045328: [Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

Description

[Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

It is reproduced in 20Q3 but not in PI

Steps To Reproduce

In the backoffice:
   Set the Web POS Save Removed Tickets preference to Y
   Create a new record in Discounts And Promotions window:
      Organization: *
      Discount Promotion Type: User Defined Percentage
      Starting date: today
      Apply Next Discount/Promotion: Y
      Included...: All excluding defined
      Percentage: 20
      Allow to Apply in Negative Lines: Y
      Log out and log in

In the POS:
   Create a new ticket
   Add Adhesive body warmers product to it
   Add the previously created discount and Apply to all lines
   Try to delete the line and check the screen is locked (grey)

The log shows:

Uncaught dodivide(): Divide by 0
D @ BigDecimal-all-1.0.3.min.js:14
v @ BigDecimal-all-1.0.3.min.js:14
div @ 24ba54b2459bf10d1c792e3d526e56ca.js:1302
div @ 24ba54b2459bf10d1c792e3d526e56ca.js:1312
pushDiscountAndUpdate @ 24ba54b2459bf10d1c792e3d526e56ca.js:2407
addDiscount @ 24ba54b2459bf10d1c792e3d526e56ca.js:2406
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2491
executeDiscountCalculation @ 24ba54b2459bf10d1c792e3d526e56ca.js:2491
calculateDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:2383
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2363
OB.Discounts.applyDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:2363
calculateLocal @ 24ba54b2459bf10d1c792e3d526e56ca.js:5426
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:5434
callbackExecutor @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
executeHooks @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
OB.Discounts.Pos.calculateDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:5434
calculateReceipt @ 24ba54b2459bf10d1c792e3d526e56ca.js:2621
postDeleteLine @ 24ba54b2459bf10d1c792e3d526e56ca.js:2664
_deleteLines @ 24ba54b2459bf10d1c792e3d526e56ca.js:2682
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2684
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2709
callbackExecutor @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
executeHooks @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
deleteLineOnceChecked @ 24ba54b2459bf10d1c792e3d526e56ca.js:2694
_deleteLine @ 24ba54b2459bf10d1c792e3d526e56ca.js:2718
_deleteLines @ 24ba54b2459bf10d1c792e3d526e56ca.js:2684

Tags

No tags attached.

Attached Files

45328_20Q3_discounts.diff [^] (718 bytes) 2020-11-11 08:57 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js b/web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
index 6eb1ccb..4557f53 100644
--- a/web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
+++ b/web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
@@ -131,6 +131,9 @@
     let totalTicketPrice = 0;
 
     ticket.lines.forEach(line => {
+      if (line.qty === 0) {
+        return;
+      }
       const lineId = line.id;
       const lineProduct = line.product;
       const lineQty = line.qty;

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on

backport

0045445

RR20Q3.2

closed

ranjith_qualiantech_com

[Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

Notes
(0124378) marvintm (manager) 2020-11-16 06:45	The problem cannot be reproduced in pi or 20Q4, but it can be reproduced in Q3 so we will do a fix for that release (as backport)

Issue History
Date Modified	Username	Field	Change
2020-10-28 18:00	ngarcia	New Issue
2020-10-28 18:00	ngarcia	Assigned To	=> Retail
2020-10-28 18:00	ngarcia	Resolution time	=> 1605654000
2020-10-28 18:00	ngarcia	Triggers an Emergency Pack	=> No
2020-10-28 18:00	ngarcia	Issue Monitored: networkb
2020-11-10 13:34	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-11-11 05:13	ranjith_qualiantech_com	Status	new => scheduled
2020-11-11 08:57	ranjith_qualiantech_com	File Added: 45328_20Q3_discounts.diff
2020-11-16 06:44	marvintm	Status	scheduled => acknowledged
2020-11-16 06:44	marvintm	Status	acknowledged => scheduled
2020-11-16 06:45	marvintm	Review Assigned To	=> marvintm
2020-11-16 06:45	marvintm	Note Added: 0124378
2020-11-16 06:45	marvintm	Status	scheduled => closed
2020-11-16 06:45	marvintm	Resolution	open => unable to reproduce