Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045328Retail ModulesDiscounts and Promotionspublic2020-10-28 18:002020-11-16 06:45
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionunable to reproduce 
PlatformOS5OS Version
Product VersionRR20Q3 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket19294
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045328: [Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount
Description[Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

It is reproduced in 20Q3 but not in PI
Steps To ReproduceIn the backoffice:
   Set the Web POS Save Removed Tickets preference to Y
   Create a new record in Discounts And Promotions window:
      Organization: *
      Discount Promotion Type: User Defined Percentage
      Starting date: today
      Apply Next Discount/Promotion: Y
      Included...: All excluding defined
      Percentage: 20
      Allow to Apply in Negative Lines: Y
      Log out and log in

In the POS:
   Create a new ticket
   Add Adhesive body warmers product to it
   Add the previously created discount and Apply to all lines
   Try to delete the line and check the screen is locked (grey)

The log shows:

Uncaught dodivide(): Divide by 0
D @ BigDecimal-all-1.0.3.min.js:14
v @ BigDecimal-all-1.0.3.min.js:14
div @ 24ba54b2459bf10d1c792e3d526e56ca.js:1302
div @ 24ba54b2459bf10d1c792e3d526e56ca.js:1312
pushDiscountAndUpdate @ 24ba54b2459bf10d1c792e3d526e56ca.js:2407
addDiscount @ 24ba54b2459bf10d1c792e3d526e56ca.js:2406
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2491
executeDiscountCalculation @ 24ba54b2459bf10d1c792e3d526e56ca.js:2491
calculateDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:2383
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2363
OB.Discounts.applyDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:2363
calculateLocal @ 24ba54b2459bf10d1c792e3d526e56ca.js:5426
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:5434
callbackExecutor @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
executeHooks @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
OB.Discounts.Pos.calculateDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:5434
calculateReceipt @ 24ba54b2459bf10d1c792e3d526e56ca.js:2621
postDeleteLine @ 24ba54b2459bf10d1c792e3d526e56ca.js:2664
_deleteLines @ 24ba54b2459bf10d1c792e3d526e56ca.js:2682
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2684
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2709
callbackExecutor @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
executeHooks @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
deleteLineOnceChecked @ 24ba54b2459bf10d1c792e3d526e56ca.js:2694
_deleteLine @ 24ba54b2459bf10d1c792e3d526e56ca.js:2718
_deleteLines @ 24ba54b2459bf10d1c792e3d526e56ca.js:2684


   
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045445RR20Q3.2 closed ranjith_qualiantech_com [Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount 
Attached Filesdiff 45328_20Q3_discounts.diff (718) 2020-11-11 08:57
https://issues.openbravo.com/file_download.php?file_id=15077&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-10-28 18:00ngarciaNew Issue
2020-10-28 18:00ngarciaAssigned To => Retail
2020-10-28 18:00ngarciaOBNetwork customer => Gold
2020-10-28 18:00ngarciaSupport ticket => 19294
2020-10-28 18:00ngarciaResolution time => 1605654000
2020-10-28 18:00ngarciaTriggers an Emergency Pack => No
2020-10-28 18:00ngarciaIssue Monitored: networkb
2020-11-10 13:34ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-11-11 05:13ranjith_qualiantech_comStatusnew => scheduled
2020-11-11 08:57ranjith_qualiantech_comFile Added: 45328_20Q3_discounts.diff
2020-11-16 06:44marvintmStatusscheduled => acknowledged
2020-11-16 06:44marvintmStatusacknowledged => scheduled
2020-11-16 06:45marvintmReview Assigned To => marvintm
2020-11-16 06:45marvintmNote Added: 0124378
2020-11-16 06:45marvintmStatusscheduled => closed
2020-11-16 06:45marvintmResolutionopen => unable to reproduce

Notes
(0124378)
marvintm   
2020-11-16 06:45   
The problem cannot be reproduced in pi or 20Q4, but it can be reproduced in Q3 so we will do a fix for that release (as backport)