Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045263
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2020-10-20 17:502020-11-06 07:24
ReporterngarciaView Statuspublic 
Assigned Toprakashmurugesan88 
PriorityhighResolutionfixedFixed in VersionRR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket19067
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045263: Some strings are considered numbers when introducing them as payments

DescriptionSome strings are considered numbers when introducing them as payments
Steps To ReproduceIn the backend:
   Configure the touchpoint type to Use External Input

In the POS:
   Add a product to the ticket
   Click on the total button
   Enter the following value in the keypad: 116K002R/0000001
   Select Cash payment
   Check a payment of 116 has been included in the ticket
Proposed SolutionWhen introducing the '116K002R/0000001' value an error message should be shown:

116K002R/0000001 is not a valid number

It happens for instance with the following value: PS1/0000001
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0124177)
hgbot (developer)
2020-11-05 04:10

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/151 [^]
(0124197)
hgbot (developer)
2020-11-06 07:24

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/151 [^]
(0124198)
hgbot (developer)
2020-11-06 07:24

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: bc19b336c36c643bfaa620f834759126a590f5dc
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-06T06:23:54+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bc19b336c36c643bfaa620f834759126a590f5dc [^]

Fixed BUG-45263: Fixes number validation on introducing payments
* Numbers are not validated properly when text starts with number and followed by non numeric characters
* Entered text is converted to parseFloat where following non numeric characters are truncated
* Fixed by validating the entered text before parseFloat conversion
* _.isNAN is not working as expected, so changed it to isNaN

---
M web/org.openbravo.retail.posterminal/js/closecash/view/closekeyboard.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---

- Issue History
Date Modified Username Field Change
2020-10-20 17:50 ngarcia New Issue
2020-10-20 17:50 ngarcia Assigned To => Retail
2020-10-20 17:50 ngarcia OBNetwork customer => Gold
2020-10-20 17:50 ngarcia Support ticket => 19067
2020-10-20 17:50 ngarcia Resolution time => 1604962800
2020-10-20 17:50 ngarcia Triggers an Emergency Pack => No
2020-11-02 08:17 prakashmurugesan88 Assigned To Retail => prakashmurugesan88
2020-11-03 07:28 ngarcia Issue Monitored: networkb
2020-11-03 07:48 prakashmurugesan88 Status new => scheduled
2020-11-05 04:10 hgbot Merge Request Status => open
2020-11-05 04:10 hgbot Note Added: 0124177
2020-11-06 07:23 hgbot Merge Request Status open => approved
2020-11-06 07:24 hgbot Resolution open => fixed
2020-11-06 07:24 hgbot Status scheduled => closed
2020-11-06 07:24 hgbot Note Added: 0124197
2020-11-06 07:24 hgbot Fixed in Version => RR21Q1
2020-11-06 07:24 hgbot Note Added: 0124198

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker