Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045263Retail ModulesWeb POSpublic2020-10-20 17:502020-11-06 07:24
Reporterngarcia 
Assigned Toprakashmurugesan88 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045263: Some strings are considered numbers when introducing them as payments
DescriptionSome strings are considered numbers when introducing them as payments
Steps To ReproduceIn the backend:
   Configure the touchpoint type to Use External Input

In the POS:
   Add a product to the ticket
   Click on the total button
   Enter the following value in the keypad: 116K002R/0000001
   Select Cash payment
   Check a payment of 116 has been included in the ticket
Proposed SolutionWhen introducing the '116K002R/0000001' value an error message should be shown:

116K002R/0000001 is not a valid number

It happens for instance with the following value: PS1/0000001
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-20 17:50ngarciaNew Issue
2020-10-20 17:50ngarciaAssigned To => Retail
2020-10-20 17:50ngarciaResolution time => 1604962800
2020-10-20 17:50ngarciaTriggers an Emergency Pack => No
2020-11-02 08:17prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-11-03 07:28ngarciaIssue Monitored: networkb
2020-11-03 07:48prakashmurugesan88Statusnew => scheduled
2020-11-05 04:10hgbotNote Added: 0124177
2020-11-06 07:24hgbotResolutionopen => fixed
2020-11-06 07:24hgbotStatusscheduled => closed
2020-11-06 07:24hgbotNote Added: 0124197
2020-11-06 07:24hgbotFixed in Version => RR21Q1
2020-11-06 07:24hgbotNote Added: 0124198

Notes
(0124177)
hgbot   
2020-11-05 04:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/151 [^]
(0124197)
hgbot   
2020-11-06 07:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/151 [^]
(0124198)
hgbot   
2020-11-06 07:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: bc19b336c36c643bfaa620f834759126a590f5dc
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-06T06:23:54+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bc19b336c36c643bfaa620f834759126a590f5dc [^]

Fixed BUG-45263: Fixes number validation on introducing payments
* Numbers are not validated properly when text starts with number and followed by non numeric characters
* Entered text is converted to parseFloat where following non numeric characters are truncated
* Fixed by validating the entered text before parseFloat conversion
* _.isNAN is not working as expected, so changed it to isNaN

---
M web/org.openbravo.retail.posterminal/js/closecash/view/closekeyboard.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---