Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0045224 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | minor | have not tried | 2020-10-14 13:27 | 2020-10-20 08:43 | |||
Reporter | jarmendariz | View Status | public | |||||
Assigned To | jarmendariz | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR21Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0045224: Remove SynchronizationBuffer listeners from Business Logic js files | |||||||
Description | SyncIconManagement is a SynchronizationBuffer listener that updates the sync icon in the WebPOS. This logic is not needed in newer applications, so it makes no sense to export this file. Same should be applied to other listeners. | |||||||
Steps To Reproduce | See above | |||||||
Proposed Solution | Move SyncIconManagement.js, CheckSourcesVersionListener.js and SyncPollingListener.js out of app/ folder and update the Component Provider. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0123679) hgbot (developer) 2020-10-14 13:32 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/83 [^] |
(0123747) hgbot (developer) 2020-10-16 13:59 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/83 [^] |
(0123748) hgbot (developer) 2020-10-16 13:59 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 7eef8125e1f3e27d29cc513462aacada7b1814af Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 2020-10-16T00:22:26+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7eef8125e1f3e27d29cc513462aacada7b1814af [^] Fixed ISSUE-45224: Moved SyncIconManagement file out of new business logic files --- A web/org.openbravo.mobile.core/source/utils/SyncIconManagement.js M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java --- |
(0123788) jarmendariz (viewer) 2020-10-20 08:32 |
SynchronizationBuffer has other listeners (polling, sources version) that should be moved away from BL as well |
(0123789) hgbot (developer) 2020-10-20 08:41 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/87 [^] |
(0123790) hgbot (developer) 2020-10-20 08:43 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/87 [^] |
(0123791) hgbot (developer) 2020-10-20 08:43 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: c95a5a92b6cf4766e049ee5c01fb10974ad0e15f Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 2020-10-20T08:39:36+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/c95a5a92b6cf4766e049ee5c01fb10974ad0e15f [^] Fixed ISSUE-45224: Removed all remaining SyncBuffer listeners from business logic SynchronizationBuffer listeners (polling, source version) contains logic only applicable in the old POS application, so it should not be in the business logic files. --- A web/org.openbravo.mobile.core/source/utils/CheckSourcesVersionListener.js A web/org.openbravo.mobile.core/source/utils/SyncPollingListener.js M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java --- |
![]() |
|||
Date Modified | Username | Field | Change |
2020-10-14 13:27 | jarmendariz | New Issue | |
2020-10-14 13:27 | jarmendariz | Assigned To | => jarmendariz |
2020-10-14 13:27 | jarmendariz | OBNetwork customer | => No |
2020-10-14 13:27 | jarmendariz | Triggers an Emergency Pack | => No |
2020-10-14 13:28 | jarmendariz | Status | new => acknowledged |
2020-10-14 13:28 | jarmendariz | Status | acknowledged => scheduled |
2020-10-14 13:32 | hgbot | Merge Request Status | => open |
2020-10-14 13:32 | hgbot | Note Added: 0123679 | |
2020-10-16 13:57 | hgbot | Merge Request Status | open => approved |
2020-10-16 13:59 | hgbot | Resolution | open => fixed |
2020-10-16 13:59 | hgbot | Status | scheduled => closed |
2020-10-16 13:59 | hgbot | Note Added: 0123747 | |
2020-10-16 13:59 | hgbot | Fixed in Version | => RR21Q1 |
2020-10-16 13:59 | hgbot | Note Added: 0123748 | |
2020-10-20 08:32 | jarmendariz | Note Added: 0123788 | |
2020-10-20 08:32 | jarmendariz | Status | closed => new |
2020-10-20 08:32 | jarmendariz | Resolution | fixed => open |
2020-10-20 08:32 | jarmendariz | Fixed in Version | RR21Q1 => |
2020-10-20 08:32 | jarmendariz | Status | new => scheduled |
2020-10-20 08:34 | jarmendariz | Summary | Remove SyncIconManagement file from Business Logic js files => Remove SynchronizationBuffer listeners from Business Logic js files |
2020-10-20 08:34 | jarmendariz | Description Updated | View Revisions |
2020-10-20 08:34 | jarmendariz | Proposed Solution updated | |
2020-10-20 08:41 | hgbot | Note Added: 0123789 | |
2020-10-20 08:43 | hgbot | Resolution | open => fixed |
2020-10-20 08:43 | hgbot | Status | scheduled => closed |
2020-10-20 08:43 | hgbot | Note Added: 0123790 | |
2020-10-20 08:43 | hgbot | Fixed in Version | => RR21Q1 |
2020-10-20 08:43 | hgbot | Note Added: 0123791 |
Copyright © 2000 - 2009 MantisBT Group |