Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045224Retail ModulesWeb POSpublic2020-10-14 13:272020-10-20 08:43
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045224: Remove SynchronizationBuffer listeners from Business Logic js files
DescriptionSyncIconManagement is a SynchronizationBuffer listener that updates the sync icon in the WebPOS. This logic is not needed in newer applications, so it makes no sense to export this file. Same should be applied to other listeners.
Steps To ReproduceSee above
Proposed SolutionMove SyncIconManagement.js, CheckSourcesVersionListener.js and SyncPollingListener.js out of app/ folder and update the Component Provider.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-14 13:27jarmendarizNew Issue
2020-10-14 13:27jarmendarizAssigned To => jarmendariz
2020-10-14 13:27jarmendarizTriggers an Emergency Pack => No
2020-10-14 13:28jarmendarizStatusnew => acknowledged
2020-10-14 13:28jarmendarizStatusacknowledged => scheduled
2020-10-14 13:32hgbotNote Added: 0123679
2020-10-16 13:59hgbotResolutionopen => fixed
2020-10-16 13:59hgbotStatusscheduled => closed
2020-10-16 13:59hgbotNote Added: 0123747
2020-10-16 13:59hgbotFixed in Version => RR21Q1
2020-10-16 13:59hgbotNote Added: 0123748
2020-10-20 08:32jarmendarizNote Added: 0123788
2020-10-20 08:32jarmendarizStatusclosed => new
2020-10-20 08:32jarmendarizResolutionfixed => open
2020-10-20 08:32jarmendarizFixed in VersionRR21Q1 =>
2020-10-20 08:32jarmendarizStatusnew => scheduled
2020-10-20 08:34jarmendarizSummaryRemove SyncIconManagement file from Business Logic js files => Remove SynchronizationBuffer listeners from Business Logic js files
2020-10-20 08:34jarmendarizDescription Updatedbug_revision_view_page.php?rev_id=21808#r21808
2020-10-20 08:34jarmendarizProposed Solution updated
2020-10-20 08:41hgbotNote Added: 0123789
2020-10-20 08:43hgbotResolutionopen => fixed
2020-10-20 08:43hgbotStatusscheduled => closed
2020-10-20 08:43hgbotNote Added: 0123790
2020-10-20 08:43hgbotFixed in Version => RR21Q1
2020-10-20 08:43hgbotNote Added: 0123791

Notes
(0123679)
hgbot   
2020-10-14 13:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/83 [^]
(0123747)
hgbot   
2020-10-16 13:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/83 [^]
(0123748)
hgbot   
2020-10-16 13:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 7eef8125e1f3e27d29cc513462aacada7b1814af
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-10-16T00:22:26+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7eef8125e1f3e27d29cc513462aacada7b1814af [^]

Fixed ISSUE-45224: Moved SyncIconManagement file out of new business logic files

---
A web/org.openbravo.mobile.core/source/utils/SyncIconManagement.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0123788)
jarmendariz   
2020-10-20 08:32   
SynchronizationBuffer has other listeners (polling, sources version) that should be moved away from BL as well
(0123789)
hgbot   
2020-10-20 08:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/87 [^]
(0123790)
hgbot   
2020-10-20 08:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/87 [^]
(0123791)
hgbot   
2020-10-20 08:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: c95a5a92b6cf4766e049ee5c01fb10974ad0e15f
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-10-20T08:39:36+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/c95a5a92b6cf4766e049ee5c01fb10974ad0e15f [^]

Fixed ISSUE-45224: Removed all remaining SyncBuffer listeners from business logic

SynchronizationBuffer listeners (polling, source version) contains logic only applicable in the old POS application,
so it should not be in the business logic files.

---
A web/org.openbravo.mobile.core/source/utils/CheckSourcesVersionListener.js
A web/org.openbravo.mobile.core/source/utils/SyncPollingListener.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---