Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045175
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorN/A2020-10-01 23:592020-11-18 13:58
Reportergorka_gilView Statuspublic 
Assigned Togorka_gil 
PriorityhighResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR20Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045175: Statistics included in cashup stopped working after moving the cashup to indexeddb

DescriptionAfter move the cashup from websql to indexeddb, all the statistics included in cashup request stopped working, this included these statistics:
- Number Of Transitions to Online
- Number Of Logclient Errors
- Average Latency in ms
- Average Upload Bandwidth in KB/s
- Average Download Bandwidth in KB/s
Steps To ReproduceIn vbs-1 terminal:
- make a cashup just for start a clean new one
- in developer tools set network in offline
- make a new ticket
- restore the online in network
- click on menu and retry connection, so the pos notice the back to online
- create a new cashup

In backend:
- go to touchpoint vbs-1
- go to the sub tab: terminal history status
- open the most recent record

The field number of transitions to online is 0, which is wrong.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0045173 closedgorka_gil Statistics included in cashup stopped working after moving the cashup to indexeddb 

-  Notes
(0124486)
hgbot (developer)
2020-11-18 13:33

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 75f70c4a35641b0b06e82fbb302dc4b3c876f6e5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-11-18T18:01:17+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/75f70c4a35641b0b06e82fbb302dc4b3c876f6e5 [^]

Fixes ISSUE-45175: Fix statistics included in cashup

- after initCashup create localStore variables in case donot exists
- after each ticket, add the statistics to the cashup include in the ticket message
- when doing a cashup include the statistics in the message
- after do a cashup, reset the statistics

When moving the cashup to indexeddb most of the code is inside actions,
and edit the local storage variables cannot be done inside the actions,
so was needed some changes respect how it works before:
- previosly the variables reset was done on init cashup from backend or
  from scratch.
  Now, it is executed in all init cashups, but only set to 0 if the variable
  doesnot exist
- Before, the reset of variables where executed at the beggining of init cashup.
  Now, is executed only after the action has finish in the then of the promise returned
  by the action (for the case that the action was canceled)
- Before, when adding the network statistics to the cashup to send to backend, there was an
  if to check if the variable exists, now it is removed since in the init cashup we ensurei that exists.

---
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/Cashup.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/CompleteCashupAndCreateNew.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup/cashup-model.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketUtils.js
---

- Issue History
Date Modified Username Field Change
2020-10-02 13:22 gorka_gil Type defect => backport
2020-10-02 13:22 gorka_gil Target Version => RR20Q4
2020-11-18 13:33 hgbot Resolution open => fixed
2020-11-18 13:33 hgbot Status scheduled => resolved
2020-11-18 13:33 hgbot Fixed in Version => RR20Q4
2020-11-18 13:33 hgbot Note Added: 0124486
2020-11-18 13:58 marvintm Review Assigned To => marvintm
2020-11-18 13:58 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker