Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045173 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | N/A | 2020-10-01 23:59 | 2020-10-05 14:10 | |||
| Reporter | gorka_gil | View Status | public | |||||
| Assigned To | gorka_gil | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR21Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045173: Statistics included in cashup stopped working after moving the cashup to indexeddb | |||||||
| Description | After move the cashup from websql to indexeddb, all the statistics included in cashup request stopped working, this included these statistics: - Number Of Transitions to Online - Number Of Logclient Errors - Average Latency in ms - Average Upload Bandwidth in KB/s - Average Download Bandwidth in KB/s | |||||||
| Steps To Reproduce | In vbs-1 terminal: - make a cashup just for start a clean new one - in developer tools set network in offline - make a new ticket - restore the online in network - click on menu and retry connection, so the pos notice the back to online - create a new cashup In backend: - go to touchpoint vbs-1 - go to the sub tab: terminal history status - open the most recent record The field number of transitions to online is 0, which is wrong. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0123484) hgbot (developer) 2020-10-02 02:16 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/119 [^] |
|
(0123487) gorka_gil (administrator) 2020-10-02 10:07 |
wiki of terminal status history, just as reference: - http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#.3DTerminal_status_history.3D [^] |
|
(0123549) hgbot (developer) 2020-10-05 14:10 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/119 [^] |
|
(0123550) hgbot (developer) 2020-10-05 14:10 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 1bdb7c2ca84b8e62edb5f01621b6d93945f3551b Author: Gorka Gil <gorka.gil@openbravo.com> Date: 2020-10-05T14:06:36+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1bdb7c2ca84b8e62edb5f01621b6d93945f3551b [^] Fixes ISSUE-45173: fix statistics included in cashup - after initCashup create localStore variables in case don't exists - after each ticket, add the statistics to the cashup include in the ticket message - when doing a cashup include the statistics in the message - after do a cashup, reset the statistics When moving the cashup to indexeddb most of the code is inside actions, and edit the local storage variables cannot be done inside the actions, so was needed some changes respect how it works before: - previosly the variables reset was done on init cashup from backend or from scratch. Now, it is executed in all init cashups, but only set to 0 if the variable doesn't exist - Before, the reset of variables where executed at the beggining of init cashup. Now, is executed only after the action has finish in the then of the promise returned by the action (for the case that the action was canceled) - Before, when adding the network statistics to the cashup to send to backend, there was an if to check if the variable exists, now it is removed since in the init cashup we ensurei that exists. --- M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/Cashup.js M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/CompleteCashupAndCreateNew.js M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js M web/org.openbravo.retail.posterminal/js/closecash/model/cashup/cashup-model.js M web/org.openbravo.retail.posterminal/js/login/model/login-model.js M web/org.openbravo.retail.posterminal/js/utils/ticketUtils.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-10-01 23:59 | gorka_gil | New Issue | |
| 2020-10-01 23:59 | gorka_gil | Assigned To | => gorka_gil |
| 2020-10-01 23:59 | gorka_gil | OBNetwork customer | => No |
| 2020-10-01 23:59 | gorka_gil | Triggers an Emergency Pack | => No |
| 2020-10-02 02:16 | hgbot | Merge Request Status | => open |
| 2020-10-02 02:16 | hgbot | Note Added: 0123484 | |
| 2020-10-02 10:07 | gorka_gil | Note Added: 0123487 | |
| 2020-10-02 13:22 | gorka_gil | Status | new => scheduled |
| 2020-10-05 13:59 | hgbot | Merge Request Status | open => approved |
| 2020-10-05 14:10 | hgbot | Resolution | open => fixed |
| 2020-10-05 14:10 | hgbot | Status | scheduled => closed |
| 2020-10-05 14:10 | hgbot | Note Added: 0123549 | |
| 2020-10-05 14:10 | hgbot | Fixed in Version | => RR21Q1 |
| 2020-10-05 14:10 | hgbot | Note Added: 0123550 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |