Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045128
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Gift cards and gift vouchersmajorhave not tried2020-09-24 10:102020-10-08 12:40
ReporterjavietxeView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045128: Expiration date of the giftcard not calculated in the POS

DescriptionThe expiration date of the giftcard is calculated while the transaction is being done to the backend. This makes that the expiration date cannot be printed by the POS.
Steps To ReproduceSet in the organization the "Credit Note expiration days"

Do a return as Gift Cards
Proposed SolutionCalculate the expiration date in the POS and send it in the payment.

In order to do this, the organization field em_gncv_creditnote_lifetime should be sent to the POS.

When creating the gift card, the expiration date is calculated with this value, set in the gift card and send it in the payment to the backend
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0051882 closedradhakrishnan Wrong expiration date printed in a Credit Note partially used 

-  Notes
(0123585)
ranjith_qualiantech_com (developer)
2020-10-07 09:17

 Caused by indexed db add payment changes
Payment data is converted to json by parsing as string. So Date object is converted to String
commit: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/197a764cb7f7eb64a9cdf82a44a5de5888e5ba4b#c7e7b1a1803a89252d22c91692bd17768ca5938e_7733_7608 [^]
(0123610)
hgbot (developer)
2020-10-08 07:25

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/27 [^]
(0123619)
hgbot (developer)
2020-10-08 12:40

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 9c6a33f75cf65fc50906bd945bb592b2e6635186
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-08T10:54:43+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/9c6a33f75cf65fc50906bd945bb592b2e6635186 [^]

Fixed ISSUE-45128: Updated ExpirationDate calculation when printing credit note
* When adding payment, expiration date is saved as string instead of date object. So date should be parsed and formatted before printing

---
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
---
(0123620)
hgbot (developer)
2020-10-08 12:40

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/27 [^]

- Issue History
Date Modified Username Field Change
2020-09-24 10:10 javietxe New Issue
2020-09-24 10:10 javietxe Assigned To => Retail
2020-09-24 10:10 javietxe Resolution time => 1602712800
2020-09-24 10:10 javietxe Triggers an Emergency Pack => No
2020-10-05 18:01 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-10-05 18:02 ranjith_qualiantech_com Status new => scheduled
2020-10-07 09:17 ranjith_qualiantech_com Note Added: 0123585
2020-10-08 07:25 hgbot Note Added: 0123610
2020-10-08 12:40 hgbot Resolution open => fixed
2020-10-08 12:40 hgbot Status scheduled => closed
2020-10-08 12:40 hgbot Note Added: 0123619
2020-10-08 12:40 hgbot Note Added: 0123620
2023-03-24 10:33 ngarcia Relationship added related to 0051882

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker